501aee9f3f
This fixes an issue created in in the fix for 4619 https://gerrit-review.googlesource.com/c/87191/ where GWT UI urls were encoded after the hash and thus resulted in 404 errors. This change fixes the issue, and also makes the _handleLocationChange testable by passing location to the event handler. This way, we can call the function with a mock event and not rely on window.location. Bug: Issue 4695 Change-Id: I983b10329ab6059bc006f4de85daa49f67137604
83 lines
2.4 KiB
HTML
83 lines
2.4 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
Copyright (C) 2016 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-app</title>
|
|
|
|
<script src="../bower_components/webcomponentsjs/webcomponents.min.js"></script>
|
|
<script src="../bower_components/web-component-tester/browser.js"></script>
|
|
|
|
<link rel="import" href="gr-app.html">
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-app id="app"></gr-app>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-app tests', function() {
|
|
var sandbox;
|
|
var element;
|
|
|
|
setup(function(done) {
|
|
sandbox = sinon.sandbox.create();
|
|
stub('gr-reporting', {
|
|
appStarted: sandbox.stub(),
|
|
});
|
|
var config = {
|
|
gerrit: {web_uis: ['GWT', 'POLYGERRIT']},
|
|
plugin: {js_resource_paths: []},
|
|
};
|
|
stub('gr-rest-api-interface', {
|
|
getConfig: function() { return Promise.resolve(config); },
|
|
});
|
|
|
|
element = fixture('basic');
|
|
flush(done);
|
|
});
|
|
teardown(function() {
|
|
sandbox.restore();
|
|
});
|
|
|
|
test('reporting', function() {
|
|
assert.isTrue(element.$.reporting.appStarted.calledOnce);
|
|
});
|
|
|
|
test('location change updates gwt footer', function() {
|
|
element._path = '/test/path';
|
|
var gwtLink = element.$$('#gwtLink');
|
|
assert.equal(gwtLink.href,
|
|
'http://' + location.host + '/?polygerrit=0#/test/path');
|
|
});
|
|
|
|
test('_handleLocationChange handles hashes', function() {
|
|
var curLocation = {
|
|
pathname: '/c/1/1/testfile.txt',
|
|
hash: '#2',
|
|
host: location.host,
|
|
};
|
|
|
|
var event = {detail: curLocation};
|
|
var gwtLink = element.$$('#gwtLink');
|
|
element._handleLocationChange(event);
|
|
assert.equal(gwtLink.href,
|
|
'http://' + location.host + '/?polygerrit=0#/c/1/1/testfile.txt@2');
|
|
});
|
|
});
|
|
</script>
|