opendev/gerrit
Code Issues Proposed changes
5568264a8f
gerrit/polygerrit-ui
History
Han-Wen Nienhuys e6c7e629c6 bazel: abstract the build system in static serving. 
Provide BazelBuild to stub out the Bazel build.

Tested:

Production use case:
1.) bazel build polygerrit && \
    $(bazel info output_base)/external/local_jdk/bin/java \
     -jar bazel-bin/polygerrit.war daemon -d ../test_site \
     --console-log --show-stack-trace

Development mode use cases:
2.) bazel build polygerrit \
      //polygerrit-ui:polygerrit_components.bower_components.zip &&
    $(bazel info output_base)/external/local_jdk/bin/java \
     -jar bazel-bin/polygerrit.war daemon \
     --polygerrit-dev -d ../gerrit_testsite --console-log --show-stack-trace

checked that updates under polygerrit-ui/app/index.html are served
live.

3.) Run tools/eclipse/project.py, started gwt_daemon launcher,
verified that it worked.

4.) Run tools/eclipse/project.py, started gerit_gwt_debug launcher,
verified that GWT SDM worked.

Change-Id: I9d105e00e953b63c78306e9e37d5152673627727
2016-11-13 07:27:17 -08:00
..
app bazel: abstract the build system in static serving. 2016-11-13 07:27:17 -08:00
.gitattributes Add the skeleton of a new UI based on Polymer, PolyGerrit 2015-11-09 22:01:28 +00:00
.gitignore Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
BUCK Serve fonts for local PolyGerrit development 2016-11-07 14:24:06 -08:00
BUILD bazel: abstract the build system in static serving. 2016-11-13 07:27:17 -08:00
README.md bazel: wct tests. 2016-11-03 13:03:03 +01:00
run-server.sh Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
server.go Return correct error code from accounts/self/detail in test server 2016-05-06 12:41:33 -04:00
wct.conf.js Add the skeleton of a new UI based on Polymer, PolyGerrit 2015-11-09 22:01:28 +00:00

README.md

PolyGerrit

Installing Node.js

# Debian/Ubuntu
sudo apt-get install nodejs-legacy

# OS X with Homebrew
brew install node

All other platforms: download from nodejs.org.

Installing Buck

Follow the instructions here to get and install Buck.

Local UI, Production Data

This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.

Installing go

This is required for running the run-server.sh script below.

# Debian/Ubuntu
sudo apt-get install golang

# OS X with Homebrew
brew install go

All other platforms: download from golang.org

Then add go to your path:

PATH=$PATH:/usr/local/go/bin

Running the server

To test the local UI against gerrit-review.googlesource.com:

./run-server.sh

Then visit http://localhost:8081

Local UI, Test Data

One-time setup:

  1. Build Gerrit
  2. Set up a local test site. Docs here and here.

When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:

buck build polygerrit && \
java -jar buck-out/gen/polygerrit/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace

Running Tests

One-time setup:

# Debian/Ubuntu
sudo apt-get install npm

# OS X with Homebrew
brew install npm

# All platforms (including those above)
sudo npm install -g web-component-tester

Run all web tests:

buck test --no-results-cache --include web

The --no-results-cache flag prevents flaky test failures from being cached.

If you need to pass additional arguments to wct:

WCT_ARGS='-p --some-flag="foo bar"' buck test --no-results-cache --include web

For interactively working on a single test file, do the following:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081/elements/foo/bar_test.html

Running tests (bazel)

Run

WCT_ARGS='--some-flag' sh polygerrit-ui/app/run_test.sh

Style guide

We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.