After removing Elasticsearch and Jest REST client library, commons lang3 is not used any more in Gerrit core and is only used for tests and not included in release.war. Given that we have forgotten to remove it and stil expose it in plugin API only confused the plugins that depend on it, because the build pass, but then the plugin cannot work, because the required dependency is missing. Similar change was already done on stable branches, but was erroneously reverted during merge to master. Bug: Issue 9253 Change-Id: Ie86b9078f5d6ba353ae2d044adefccb182a015ba
		
			
				
	
	
		
			134 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			134 lines
		
	
	
		
			4.2 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
load("//tools/bzl:genrule2.bzl", "genrule2")
 | 
						|
load(
 | 
						|
    "//tools/bzl:plugins.bzl",
 | 
						|
    "CORE_PLUGINS",
 | 
						|
    "CUSTOM_PLUGINS",
 | 
						|
)
 | 
						|
 | 
						|
genrule2(
 | 
						|
    name = "core",
 | 
						|
    srcs = ["//plugins/%s:%s.jar" % (n, n) for n in CORE_PLUGINS + CUSTOM_PLUGINS],
 | 
						|
    outs = ["core.zip"],
 | 
						|
    cmd = "mkdir -p $$TMP/WEB-INF/plugins;" +
 | 
						|
          "for s in $(SRCS) ; do " +
 | 
						|
          "ln -s $$ROOT/$$s $$TMP/WEB-INF/plugins;done;" +
 | 
						|
          "cd $$TMP;" +
 | 
						|
          "zip -qr $$ROOT/$@ .",
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
)
 | 
						|
 | 
						|
PLUGIN_API = [
 | 
						|
    "//java/com/google/gerrit/server",
 | 
						|
    "//java/com/google/gerrit/server/restapi",
 | 
						|
    "//java/com/google/gerrit/pgm/init/api",
 | 
						|
    "//java/com/google/gerrit/httpd",
 | 
						|
    "//java/com/google/gerrit/sshd",
 | 
						|
]
 | 
						|
 | 
						|
EXPORTS = [
 | 
						|
    "//java/com/google/gerrit/common:annotations",
 | 
						|
    "//java/com/google/gerrit/common:server",
 | 
						|
    "//java/com/google/gerrit/extensions:api",
 | 
						|
    "//java/com/google/gerrit/index",
 | 
						|
    "//java/com/google/gerrit/index:query_exception",
 | 
						|
    "//java/com/google/gerrit/index:query_parser",
 | 
						|
    "//java/com/google/gerrit/lifecycle",
 | 
						|
    "//java/com/google/gerrit/metrics",
 | 
						|
    "//java/com/google/gerrit/metrics/dropwizard",
 | 
						|
    "//java/com/google/gerrit/reviewdb:server",
 | 
						|
    "//java/com/google/gerrit/util/http",
 | 
						|
    "//lib/commons:dbcp",
 | 
						|
    "//lib/commons:lang",
 | 
						|
    "//lib/dropwizard:dropwizard-core",
 | 
						|
    "//lib/flogger:api",
 | 
						|
    "//lib/guice:guice",
 | 
						|
    "//lib/guice:guice-assistedinject",
 | 
						|
    "//lib/guice:guice-servlet",
 | 
						|
    "//lib/guice:javax_inject",
 | 
						|
    "//lib/httpcomponents:httpclient",
 | 
						|
    "//lib/httpcomponents:httpcore",
 | 
						|
    "//lib/jackson:jackson-core",
 | 
						|
    "//lib/jgit/org.eclipse.jgit.http.server:jgit-servlet",
 | 
						|
    "//lib/jgit/org.eclipse.jgit:jgit",
 | 
						|
    "//lib/log:api",
 | 
						|
    "//lib/log:log4j",
 | 
						|
    "//lib/mina:sshd",
 | 
						|
    "//lib/ow2:ow2-asm",
 | 
						|
    "//lib/ow2:ow2-asm-analysis",
 | 
						|
    "//lib/ow2:ow2-asm-commons",
 | 
						|
    "//lib/ow2:ow2-asm-util",
 | 
						|
    "//lib:args4j",
 | 
						|
    "//lib:blame-cache",
 | 
						|
    "//lib:guava",
 | 
						|
    "//lib:guava-retrying",
 | 
						|
    "//lib:gson",
 | 
						|
    "//lib:gwtorm",
 | 
						|
    "//lib:icu4j",
 | 
						|
    "//lib:jsch",
 | 
						|
    "//lib:mime-util",
 | 
						|
    "//lib:protobuf",
 | 
						|
    "//lib:servlet-api-3_1-without-neverlink",
 | 
						|
    "//lib:soy",
 | 
						|
    "//prolog:gerrit-prolog-common",
 | 
						|
]
 | 
						|
 | 
						|
java_binary(
 | 
						|
    name = "plugin-api",
 | 
						|
    main_class = "Dummy",
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
    runtime_deps = [":plugin-lib"],
 | 
						|
)
 | 
						|
 | 
						|
java_library(
 | 
						|
    name = "plugin-lib",
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
    exports = PLUGIN_API + EXPORTS,
 | 
						|
)
 | 
						|
 | 
						|
java_library(
 | 
						|
    name = "plugin-lib-neverlink",
 | 
						|
    neverlink = 1,
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
    exports = PLUGIN_API + EXPORTS,
 | 
						|
)
 | 
						|
 | 
						|
java_binary(
 | 
						|
    name = "plugin-api-sources",
 | 
						|
    main_class = "Dummy",
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
    runtime_deps = [
 | 
						|
        "//java/com/google/gerrit/common:libannotations-src.jar",
 | 
						|
        "//java/com/google/gerrit/common:libserver-src.jar",
 | 
						|
        "//java/com/google/gerrit/extensions:libapi-src.jar",
 | 
						|
        "//java/com/google/gerrit/httpd:libhttpd-src.jar",
 | 
						|
        "//java/com/google/gerrit/index:libindex-src.jar",
 | 
						|
        "//java/com/google/gerrit/index:libquery_exception-src.jar",
 | 
						|
        "//java/com/google/gerrit/index:libquery_parser-src.jar",
 | 
						|
        "//java/com/google/gerrit/pgm/init/api:libapi-src.jar",
 | 
						|
        "//java/com/google/gerrit/reviewdb:libserver-src.jar",
 | 
						|
        "//java/com/google/gerrit/server:libserver-src.jar",
 | 
						|
        "//java/com/google/gerrit/server/restapi:librestapi-src.jar",
 | 
						|
        "//java/com/google/gerrit/sshd:libsshd-src.jar",
 | 
						|
        "//java/com/google/gerrit/util/http:libhttp-src.jar",
 | 
						|
    ],
 | 
						|
)
 | 
						|
 | 
						|
load("//tools/bzl:javadoc.bzl", "java_doc")
 | 
						|
 | 
						|
java_doc(
 | 
						|
    name = "plugin-api-javadoc",
 | 
						|
    libs = PLUGIN_API + [
 | 
						|
        "//java/com/google/gerrit/index",
 | 
						|
        "//java/com/google/gerrit/index:query_exception",
 | 
						|
        "//java/com/google/gerrit/index:query_parser",
 | 
						|
        "//java/com/google/gerrit/common:annotations",
 | 
						|
        "//java/com/google/gerrit/common:server",
 | 
						|
        "//java/com/google/gerrit/extensions:api",
 | 
						|
        "//java/com/google/gerrit/reviewdb:server",
 | 
						|
        "//java/com/google/gerrit/util/http",
 | 
						|
    ],
 | 
						|
    pkgs = ["com.google.gerrit"],
 | 
						|
    title = "Gerrit Review Plugin API Documentation",
 | 
						|
    visibility = ["//visibility:public"],
 | 
						|
)
 |