opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
9,323 Commits 1 Branch 360 Tags 120 MiB
5a32a6dc15
Go to file
David Ostrovsky 5a32a6dc15 Fix submit rule evaluation for non blocking labels 
Putting a negative score on a label configured as `NoBlock` causes
the submit button to be disabled.  However, a `NoBlock` label is
supposed to be purely informational and its values not considered
when determining whether a change is submittable.

Fix the submit rule evaluation to prevent the button from being
disabled.

Also add an integration test.

Bug: Issue 2453
Change-Id: I0825b3c2d4774c17d523ac5f7890b983fa07af39
2014-02-25 11:02:37 +09:00
.settings Suppress Eclipse warning "annotation should not be used as a superinterface" 2013-05-10 10:31:19 -07:00
contrib Improve the bash completion script installation instructions 2013-09-27 10:18:30 +09:00
Documentation Fix minor typo in REST API accounts documentation 2014-02-21 12:30:53 +09:00
gerrit-acceptance-tests Fix submit rule evaluation for non blocking labels 2014-02-25 11:02:37 +09:00
gerrit-antlr Document that QueryParseException message is shown to end users 2013-08-22 11:51:26 -07:00
gerrit-cache-h2 Merge branch 'stable-2.7' into stable-2.8 2013-11-05 11:15:47 -08:00
gerrit-common ChangeScreen2: Make diff against revision persistent 2013-11-25 03:06:09 -05:00
gerrit-extension-api Support 'id' attribute for menu items contributed by plugins 2013-11-06 09:24:47 +01:00
gerrit-gwtdebug Delete Maven based build 2013-05-21 20:28:56 -07:00
gerrit-gwtexpui SideBySide2: Restore some old keybindings and fix help popup 2013-11-07 11:02:32 +00:00
gerrit-gwtui SideBySide2: Fill the browser width 2014-02-07 18:44:09 +09:00
gerrit-httpd AllRequestFilter: delegate to the filters for init and destroy phases too 2013-12-09 10:55:56 +00:00
gerrit-launcher Stop packaging joda time in root of gerrit.war 2014-02-04 21:15:11 +01:00
gerrit-lucene Support committing Lucene writes within a fixed interval 2014-02-17 14:29:21 -05:00
gerrit-main Delete Maven based build 2013-05-21 20:28:56 -07:00
gerrit-openid Miscellaneous Javadoc cleanups to cut down on Eclipse warnings 2013-10-09 12:18:31 -07:00
gerrit-patch-commonsnet Delete Maven based build 2013-05-21 20:28:56 -07:00
gerrit-patch-jgit Remove unnecessary imports 2013-11-03 12:36:39 +04:00
gerrit-pgm Run most acceptance tests in-memory 2013-11-05 14:41:03 -08:00
gerrit-plugin-api Delete Maven based build 2013-05-21 20:28:56 -07:00
gerrit-plugin-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-gwt-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-gwtui Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-plugin-js-archetype Update Gerrit API version to 2.8.1 in pom files 2014-01-15 09:46:58 +09:00
gerrit-prettify Fix ArrayIndexOutOfBoundsException on intraline diff again 2014-02-10 13:37:05 -06:00
gerrit-reviewdb Fixed the spelling of indefinitely. 2013-11-26 20:30:01 -07:00
gerrit-server Fix submit rule evaluation for non blocking labels 2014-02-25 11:02:37 +09:00
gerrit-solr Fix last line of license headers 2013-10-14 17:40:17 +00:00
gerrit-sshd Pass recursive=true into config.getNames() JGit method 2014-01-30 17:22:06 +01:00
gerrit-util-cli Remove jsr305 library 2013-09-26 23:12:55 -07:00
gerrit-util-ssl Delete Maven based build 2013-05-21 20:28:56 -07:00
gerrit-war Merge branch 'stable-2.7' into stable-2.8 2013-11-08 21:16:47 -08:00
lib Bump JGit version to 3.2.0.201312181205-r 2014-01-30 17:07:44 +01:00
plugins Update the revision of the cookbook plugin 2014-02-21 17:29:06 +09:00
ReleaseNotes Update the 2.8.2 release notes with recently merged fixes 2014-02-18 19:14:22 +09:00
tools Buck: Decouple plugin-api installation from deployment 2014-02-10 23:20:09 +01:00
website/releases Update release website index to use new documentation site 2013-10-17 17:07:30 +09:00
.buckconfig Update Buck to latest master 2013-09-20 19:41:26 -07:00
.buckversion Update Buck 2013-11-05 21:38:53 +00:00
.gitignore Add org.eclipse.ltk.core.refactoring.prefs to .gitignore 2013-07-11 18:02:25 +09:00
.gitmodules Set git submodules back to relative paths 2013-10-29 17:04:35 +09:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Buck: add build for gerrit-plugin-gwtui 2013-12-05 17:20:26 +09:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Bump VERSION to 2.8.1 2014-01-15 09:43:25 +09:00