Since bottom-up to top-down graph traversal switch in Buck, only first order dependencies are built per default. This leads to a problem when gerrit is built without --deep option (per default). Move gwt-dev dependencies to gwt_binary() rules. The correct fix for this issue would be to model the GWT compiler as a tool, and ensure that its transitive deps are added as first order deps of the gwt_binary() rules: [1]. Put this workaround for now in tree and fix build breakages. We can always improve things when Buck supports that new model. Test plan: * buck clean * change one of GWT classes * buck build //gerrit-gwtui:ui_opt * buck build api_install [1] https://github.com/facebook/buck/issues/469 Change-Id: I4212ac327acd27f33256c1ba1e86c0b098e07a93
		
			
				
	
	
		
			25 lines
		
	
	
		
			487 B
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			25 lines
		
	
	
		
			487 B
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
GWT_JVM_ARGS = ['-Xmx512m']
 | 
						|
 | 
						|
GWT_COMPILER_ARGS = [
 | 
						|
  '-XdisableClassMetadata',
 | 
						|
]
 | 
						|
 | 
						|
GWT_COMPILER_ARGS_RELEASE_MODE = GWT_COMPILER_ARGS + [
 | 
						|
  '-XdisableCastChecking',
 | 
						|
]
 | 
						|
 | 
						|
GWT_PLUGIN_DEPS = [
 | 
						|
  '//gerrit-plugin-gwtui:gwtui-api-lib',
 | 
						|
  '//lib/gwt:user',
 | 
						|
]
 | 
						|
 | 
						|
GWT_TRANSITIVE_DEPS = [
 | 
						|
  '//lib/gwt:javax-validation',
 | 
						|
  '//lib/gwt:javax-validation_src',
 | 
						|
  '//lib/ow2:ow2-asm',
 | 
						|
  '//lib/ow2:ow2-asm-analysis',
 | 
						|
  '//lib/ow2:ow2-asm-commons',
 | 
						|
  '//lib/ow2:ow2-asm-tree',
 | 
						|
  '//lib/ow2:ow2-asm-util',
 | 
						|
]
 |