64451c001a
The UX for moving an account from the CC reviewer state to REVIEWER requires the user to first mark the account for pending removal from the CC field. This queues the account to be moved to the REMOVED state immediately after the review is posted. Sending the reply causes the backend to move such accounts to their new reviewer state as the user intended. However, we were immediately deleting them from the reviewer set after posting the review. There was no accommodation for removed accounts that are readded. This change keeps track of accounts moving between states. They continue to be queued for deletion when the user removes them, but any removed account that gets readded by posting the review is now skipped during the followup purge. Bug: Issue 5323 Change-Id: I5918d601314504a2ca072a7f36d76bc62221803b
PolyGerrit
Installing Node.js
# Debian/Ubuntu
sudo apt-get install nodejs-legacy
# OS X with Homebrew
brew install node
All other platforms: download from nodejs.org.
Installing Bazel
Follow the instructions here to get and install Bazel.
Local UI, Production Data
This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.
Installing go
This is required for running the run-server.sh script below.
# Debian/Ubuntu
sudo apt-get install golang
# OS X with Homebrew
brew install go
All other platforms: download from golang.org
Then add go to your path:
PATH=$PATH:/usr/local/go/bin
Running the server
To test the local UI against gerrit-review.googlesource.com:
./run-server.sh
Then visit http://localhost:8081
Local UI, Test Data
One-time setup:
- Build Gerrit
- Set up a local test site. Docs here and here.
When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:
bazel build polygerrit && \
java -jar bazel-bin/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace
Running Tests
One-time setup:
# Debian/Ubuntu
sudo apt-get install npm
# OS X with Homebrew
brew install npm
# All platforms (including those above)
sudo npm install -g web-component-tester
Run all web tests:
./polygerrit-ui/app/run_test.sh
If you need to pass additional arguments to wct:
WCT_ARGS='-p --some-flag="foo bar"' ./polygerrit-ui/app/run_test.sh
For interactively working on a single test file, do the following:
./polygerrit-ui/run-server.sh
Then visit http://localhost:8081/elements/foo/bar_test.html
Style guide
We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.