66252ed8ea
At the moment log4j configuration is a bit inconsistent: it is possible to configure error_log and gc_log using file provided with log4j.configuration system property, however httpd_log and sshd_log configuration is hard-coded in corresponding classes (HttpLog and SshLog). Make logs configuration more consistent by using log4j for all logs. If log4j.configuration variable is not set, log behavior remains intact and code-level log configuration will be used. In case of log4.configuration points to log4j.properties file the hard-coded configuration will be ommited and log4j.properties will be used instead. In addition shouldConfigureLogSystem() call moved from ErrorLogFile to LogUtil in com.google.gerrit.util package and removed deprecated reference to log4j LogManager.DEFAULT_CONFIGURATION_KEY so that gerrit common does not require log4j. Two inner MyLayout classes (one from SshLog and one from HttpLog) have been extracted to separate files and renamed accordingly to enable to use them from log4j.properties file if required. At the moment those are extracted as is - refactoring will follow. Change-Id: Icb1a3787b98392a9df9bb2afa4dc857f8cfada3a Signed-off-by: Eryk Szymanski <eryksz@gmail.com>