6724617e25
The current implementation of TreeCreator can't handle TreeModifications which refer to the same files even when those modifications are specified in a logical order. Fixing this turned out to be more difficult than expected as TreeCreator acts on top of JGit library functions and those functions don't seem to support such overlapping modifications out of the box. None of our production code can currently create such overlapping modifications. As TreeCreator behaves unexpectedly when presented with such TreeModifications (sometimes throwing an exception, sometimes creating a new tree with some ignored modifications), we thought it was still helpful to explicitly throw an exception and document that unsupported behavior. That exception also proves useful for the test API of changes. When developers try to create a new patchset with impossible file combinations (e.g. delete + add the same file; rename without content modification + provide different content for new file name), they see a message which explicitly warns them instead of a strange error or a silently but possibly wrongly succeeding test. Change-Id: I17a20a2bc5a16ac7719d04fe1a7c3e2dcbbef5d6
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.