opendev/gerrit
Code Issues Proposed changes
67a3330950
gerrit/polygerrit-ui
History
Wyatt Allen afbc603265 Remove unused syntax elements 
The syntax layer sometimes emitted syntax annotations which did not have
corresponding styles, making the resulting elements dead weight in the
DOM. With this change, the syntax layer only attaches the subset of
syntax annotations which have styles by comparing them against a
whitelist.

Change-Id: Id6ced6df2ef765abd3d93cd4798381726619230b
2016-08-11 10:42:17 -07:00
..
app Remove unused syntax elements 2016-08-11 10:42:17 -07:00
.gitattributes Add the skeleton of a new UI based on Polymer, PolyGerrit 2015-11-09 22:01:28 +00:00
.gitignore Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
BUCK Syntax highlighting 2016-07-25 13:47:30 -07:00
README.md Update PolyGerrit dev README.md 2016-08-01 12:16:57 -04:00
run-server.sh Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
server.go Return correct error code from accounts/self/detail in test server 2016-05-06 12:41:33 -04:00
wct.conf.js Add the skeleton of a new UI based on Polymer, PolyGerrit 2015-11-09 22:01:28 +00:00

README.md

PolyGerrit

Installing Node.js

# Debian/Ubuntu
sudo apt-get install nodejs-legacy

# OS X with Homebrew
brew install node

All other platforms: download from nodejs.org.

Optional: installing go

This is only required for running the run-server.sh script for testing. See below.

# Debian/Ubuntu
sudo apt-get install golang

# OS X with Homebrew
brew install go

All other platforms: download from golang.org

Add [go] to your path

PATH=$PATH:/usr/local/go/bin

Local UI, Production Data

To test the local UI against gerrit-review.googlesource.com:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081

Local UI, Test Data

One-time setup:

  1. Install Buck for building Gerrit.
  2. Build Gerrit and set up a local test site. Docs here and here.

When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:

buck build polygerrit && \
java -jar buck-out/gen/polygerrit/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace

Running Tests

One-time setup:

# Debian/Ubuntu
sudo apt-get install npm

# OS X with Homebrew
brew install npm

# All platforms (including those above)
sudo npm install -g web-component-tester

Run all web tests:

buck test --no-results-cache --include web

The --no-results-cache flag prevents flaky test failures from being cached.

If you need to pass additional arguments to wct:

WCT_ARGS='-p --some-flag="foo bar"' buck test --no-results-cache --include web

For interactively working on a single test file, do the following:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081/elements/foo/bar_test.html

Style guide

We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.