opendev/gerrit
Code Issues Proposed changes
67c263f877
gerrit/Documentation
History
David Pursehouse 4a159a1edf Replace "line" with "end_line" when range is given in inline comment 
When a range comment is given in the review, the caller must specify
the "range" entity with "start_line" and "end_line" values, and also
the "line" value.

The documentation simply says that the "line" value 'should equal the
end line of the range', but the implementation does not validate this.

If "line" is not specified, the comment is added as a file comment
regardless of what "start_line" and "end_line" values are given in
the range. This can be confusing for users.

Change it so that when a "range" is given, the "line" value is not
necessary, and if given at all will be overridden with the value from
the "range"

Bug: Issue 2861
Change-Id: I5d0d31c392937b1955572781375fc48982ea7664
2014-08-27 21:58:51 +09:00
..
images Review UI docs: Add screenshot of side-by-side diff with renamed file 2014-06-06 10:38:37 +02:00
man Add SSH command to set group members 2013-06-14 20:30:32 +02:00
.gitignore Documentation/Makefile: Remove SVN publish support 2014-05-19 13:42:34 -07:00
access-control.txt Add 'View Plugins' global capability that allows to list plugins 2014-05-09 19:51:00 +02:00
asciidoc.conf Add asciidoc build back in the Documentation folder 2014-05-14 11:05:42 +09:00
asciidoc.defs Update Buck 2013-11-29 10:50:59 -08:00
BUCK Simplify documentation indexer 2014-01-08 14:01:42 -08:00
cmd-apropos.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ban-commit.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-cherry-pick.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-account.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-branch.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-group.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-project.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
cmd-flush-caches.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-gc.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-gsql.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-hook-commit-msg.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-index.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-kill.txt Revert "== GERRIT" in documentation. 2014-03-25 19:44:49 +00:00
cmd-ls-groups.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ls-members.txt Documentation: Format fix headlines 2014-03-24 18:32:42 -07:00
cmd-ls-projects.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ls-user-refs.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-enable.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-install.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-ls.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-reload.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-remove.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-query.txt SSH query command: Remove resume_sortkey query operator 2014-08-11 09:41:32 -07:00
cmd-receive-pack.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-rename-group.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-review.txt Update review command documentation for mutually exclusive options 2014-08-26 09:24:54 -04:00
cmd-set-account.txt Fix description of set-account command's --full-name option 2014-08-20 02:30:08 +00:00
cmd-set-members.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-set-project-parent.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-set-project.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
cmd-set-reviewers.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-show-caches.txt Documentation: Update example output of show-caches SSH command 2014-05-23 11:22:00 +02:00
cmd-show-connections.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-show-queue.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-stream-events.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-suexec.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-test-submit-rule.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-test-submit-type.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-version.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-auto-site-initialization.txt Control which plugins will be auto installed on auto init 2014-02-24 11:11:04 +01:00
config-cla.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-contact.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-gerrit.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
config-gitweb.txt Documentation: Case consistencies for SEE ALSO 2014-03-24 19:02:08 -07:00
config-hooks.txt Documentation: Case consistencies for SEE ALSO 2014-03-24 19:02:08 -07:00
config-labels.txt Make Code-Review label values' meaning clear to non-maintainers 2014-01-23 10:42:41 +04:00
config-login-register.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-mail.txt Documentation: Case consistencies for SEE ALSO 2014-03-24 19:02:08 -07:00
config-project-config.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
config-reverseproxy.txt Apache/mod_jk/web server: Describe ForwardURICompatUnparsed option 2014-06-05 09:47:13 +02:00
config-sso.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-themes.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-validation.txt Add extension point to allow plugins to validate group creation 2014-01-24 11:15:33 +01:00
config.defs Disable "Last updated" footer in asciidoctor HTML 2013-10-08 17:45:39 +00:00
database-setup.txt Merge branch 'stable-2.8' into stable-2.9 2014-07-08 18:24:26 +09:00
dev-buck.txt Buck: Deploy plugin artifacts to Maven Central 2014-05-26 22:06:42 +02:00
dev-build-plugins.txt Add HOWTO documentation about building of plugins 2014-01-24 23:16:25 +01:00
dev-contributing.txt Support pagination using offsets instead of sortkey 2014-02-12 13:51:26 -08:00
dev-design.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-eclipse.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-inspector.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-plugins.txt Update archetype version in plugin documentation to 2.9 2014-06-04 07:14:31 +00:00
dev-readme.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-release-deploy-config.txt Document more details about the deploy configuration for Maven Central 2014-06-03 20:11:53 +02:00
dev-release-subproject.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-release.txt Release documentation: Add URL to Gerrit artifacts on Maven Central 2014-06-04 14:24:20 +02:00
dev-rest-api.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
doc.css Documentation: Fix REST API example box width 2014-05-15 05:41:11 +00:00
error-branch-not-found.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-change-closed.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-change-does-not-belong-to-project.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-change-not-found.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-change-upload-blocked.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-commit-already-exists.txt Merge branch 'stable-2.8' 2014-03-11 18:24:13 +09:00
error-contains-banned-commit.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-has-duplicates.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-invalid-author.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-invalid-changeid-line.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-invalid-committer.txt Fix reference to Forge Committer access right in documentation 2014-07-08 07:24:01 +00:00
error-messages.txt Improve reject message if Change-Id is in subject 2014-02-21 09:25:33 +01:00
error-missing-changeid.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-missing-subject.txt Improve reject message if Change-Id is in subject 2014-02-21 09:25:33 +01:00
error-multiple-changeid-lines.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-no-changes-made.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-no-common-ancestry.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-no-new-changes.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-non-fast-forward.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-a-gerrit-administrator.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-allowed-to-upload-merges.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-permitted-to-create.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-signed-off-by.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-valid-ref.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-permission-denied.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-prohibited-by-gerrit.txt Merge branch 'stable-2.8' 2014-02-21 10:37:47 +09:00
error-project-not-found.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-push-fails-due-to-commit-message.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-squash-commits-first.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-upload-denied.txt Added searchbox to documentation. 2013-11-05 12:49:43 -08:00
gen_licenses.py Rename licenses.py to gen_licenses.py 2013-05-18 14:08:02 -07:00
i18n-readme.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
index.txt Link new review UI documentation from new change screen welcome popup 2014-05-09 16:10:27 +02:00
install-j2ee.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
install-quick.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
install.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
intro-project-owner.txt Allow to download reposize.sh script from Gerrit 2014-05-09 16:20:51 +02:00
intro-quick.txt intro-quick: Include updated change into push output 2014-05-13 16:10:39 +02:00
js-api.txt Allow plugins to refresh Gerrit's menu bar 2014-04-15 11:26:55 +02:00
json.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
Makefile Documentation/Makefile: Remove SVN publish support 2014-05-19 13:42:34 -07:00
pgm-daemon.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-gsql.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-index.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-init.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-LocalUsernamesToLowerCase.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
pgm-prolog-shell.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-reindex.txt Document the --recheck-mergeable flag for the reindex program 2014-01-22 19:22:03 +09:00
pgm-rulec.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
project-configuration.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
prolog-change-facts.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
prolog-cookbook.txt Describe labels and submit rules in project owner guide 2014-04-22 13:50:43 +02:00
replace_macros.py Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
rest-api-access.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
rest-api-accounts.txt Add 'View Plugins' global capability that allows to list plugins 2014-05-09 19:51:00 +02:00
rest-api-changes.txt Replace "line" with "end_line" when range is given in inline comment 2014-08-27 21:58:51 +09:00
rest-api-config.txt Add 'View Plugins' global capability that allows to list plugins 2014-05-09 19:51:00 +02:00
rest-api-documentation.txt Link new review UI documentation from new change screen welcome popup 2014-05-09 16:10:27 +02:00
rest-api-groups.txt Merge branch 'stable-2.8' into stable-2.9 2014-04-21 10:46:13 +09:00
rest-api-plugins.txt Add 'View Plugins' global capability that allows to list plugins 2014-05-09 19:51:00 +02:00
rest-api-projects.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
rest-api.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
user-changeid.txt Merge "Improved documentation on the Change-Ids" 2013-12-21 04:07:00 +00:00
user-dashboards.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
user-notify.txt Add section about email notifications to project owner guide 2014-04-22 13:50:55 +02:00
user-review-ui.txt Review UI docs: Add screenshot of side-by-side diff with renamed file 2014-06-06 10:38:37 +02:00
user-search.txt Describe most important search updates in 2.9 release notes 2014-05-15 13:56:08 +09:00
user-signedoffby.txt Revert "== GERRIT" in documentation. 2014-03-25 19:44:49 +00:00
user-submodules.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
user-upload.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00