
This change adds keyboard shortcuts for expanding and collapsing all messages on change views for feature parody with the GWT UI. The 'x' key expands all comments, and the 'z' key collapses all comments. In addition, the expand all/collapse all text on toggle button changes when the keyboard shortcuts are pressed (i.e. when x is clicked and all messages expand, the text will change to 'Collapse All'). Bug: Issue 5193 Change-Id: Ia60abe22eec3ef9b4ab5baebdb74d13f3efa8eeb
PolyGerrit
Installing Node.js
# Debian/Ubuntu
sudo apt-get install nodejs-legacy
# OS X with Homebrew
brew install node
All other platforms: download from nodejs.org.
Installing Buck
Follow the instructions here to get and install Buck.
Local UI, Production Data
This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.
Installing go
This is required for running the run-server.sh
script below.
# Debian/Ubuntu
sudo apt-get install golang
# OS X with Homebrew
brew install go
All other platforms: download from golang.org
Then add go to your path:
PATH=$PATH:/usr/local/go/bin
Running the server
To test the local UI against gerrit-review.googlesource.com:
./run-server.sh
Then visit http://localhost:8081
Local UI, Test Data
One-time setup:
- Build Gerrit
- Set up a local test site. Docs here and here.
When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:
buck build polygerrit && \
java -jar buck-out/gen/polygerrit/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace
Running Tests
One-time setup:
# Debian/Ubuntu
sudo apt-get install npm
# OS X with Homebrew
brew install npm
# All platforms (including those above)
sudo npm install -g web-component-tester
Run all web tests:
buck test --no-results-cache --include web
The --no-results-cache
flag prevents flaky test failures from being
cached.
If you need to pass additional arguments to wct
:
WCT_ARGS='-p --some-flag="foo bar"' buck test --no-results-cache --include web
For interactively working on a single test file, do the following:
./polygerrit-ui/run-server.sh
Then visit http://localhost:8081/elements/foo/bar_test.html
Running tests (bazel)
Run
WCT_ARGS='--some-flag' sh polygerrit-ui/app/run_test.sh
Style guide
We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.