a88f8c82d4
Previously, there was an issue where if you create a draft comment in side by side view and switch to unified view, the comment thinks it's in the later patch set rather than the earlier one and a second copy gets added to local storage with the later patchset as a component of the key. This was because the the thread group assumed all threads inside of it had the same patch number. This change fixes that, so in the event that a user switches from side by side to unified, the patch number will get taken from the comment rather than the thread group. Bug: Issue 5493 Change-Id: I7f00997bcb2e6f1001a5d58ac206acf5af3367d2
46 lines
1.5 KiB
HTML
46 lines
1.5 KiB
HTML
<!--
|
|
Copyright (C) 2017 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
|
<link rel="import" href="../gr-diff-comment-thread/gr-diff-comment-thread.html">
|
|
|
|
<dom-module id="gr-diff-comment-thread-group">
|
|
<template>
|
|
<style>
|
|
:host {
|
|
display: block;
|
|
white-space: normal;
|
|
}
|
|
gr-diff-comment-thread + gr-diff-comment-thread {
|
|
margin-top: .2em;
|
|
}
|
|
</style>
|
|
<template is="dom-repeat" items="[[_threads]]"
|
|
as="thread">
|
|
<gr-diff-comment-thread
|
|
comments="[[thread.comments]]"
|
|
comment-side="[[thread.commentSide]]"
|
|
change-num="[[changeNum]]"
|
|
location-range="[[thread.locationRange]]"
|
|
patch-num="[[thread.patchNum]]"
|
|
path="[[path]]"
|
|
side="[[side]]"
|
|
project-config="[[projectConfig]]"></gr-diff-comment-thread>
|
|
</template>
|
|
</template>
|
|
<script src="gr-diff-comment-thread-group.js"></script>
|
|
</dom-module>
|