gerrit/tools/gwt-constants.defs
David Ostrovsky d7b40c70fe Buck: Disable cast checking in GWT compiler only in release mode
DisableCastChecking option was first added in I5dc633d5b. Since Issue
3389, that caused breakage of all Google products for many weeks, this
option is added again in the development build to prevent such severe
regressions in future.

Because the generated javascript code is bigger with cast checks, this
option is still added in release mode.

Side effect of this change is that the plugins that expose GWT module
are compiled without DisableCastChecking option in Gerrit tree mode.
Standalone bucklets driven build mode is not affected by this change.

Another side effect, that 'soyc' target for "compiler story" was
duplicated and the corresponding release mode with DisableCastChecking
is also provided with alias 'soyc_r'.

TEST PLAN:

  $ buck build gerrit

should pass only -XdisableClassMetadata option to GWT compiler. Whereas

  $ buck build release

should pass both -XdisableClassMetadata -XdisableCastChecking options.

Bug: Issue 3389
Change-Id: Ia99647357e7bff889137d4855e9c0059e6c6a4f3
2015-06-05 18:47:06 +02:00

22 lines
402 B
Plaintext

GWT_JVM_ARGS = ['-Xmx512m']
GWT_COMPILER_ARGS = [
'-XdisableClassMetadata',
]
GWT_COMPILER_ARGS_RELEASE_MODE = GWT_COMPILER_ARGS + [
'-XdisableCastChecking',
]
GWT_COMMON_DEPS = [
'//lib/ow2:ow2-asm',
'//lib/ow2:ow2-asm-analysis',
'//lib/ow2:ow2-asm-util',
'//lib/ow2:ow2-asm-tree',
]
GWT_PLUGIN_DEPS = GWT_COMMON_DEPS + [
'//gerrit-plugin-gwtui:gwtui-api-lib',
'//lib/gwt:user',
]