RETIRED, Gerrit as used by OpenStack
Go to file
Jan Opacki 72fa3c2422 Fix change stuck in SUBMITTED state but actually merged
This behavior is caused by submitting a commit that has a tag.
Method MergeUtil.markCleanMerges is used by each merge strategy
to update the status of a change if it was a clean merge. It skips
commits that are identified as accepted and their entire ancestry
chain. If a commit is tagged, method MergeOp.getAlreadyAccepted
identifies it as accepted (even if it is not merged yet).
Fix prevents a commit that is referred by a tag to be included in
alreadyAccepted set. If such commit is already merged then it will
be covered anyway by adding heads to alreadyAccepted.

Add a corresponding test that pushes a commit with a tag

Bug: Issue 600
Change-Id: If00247b809b985eaf60ef5ef09fad0f475fb06b9
(cherry picked from commit b22ee233f1)
2013-09-18 17:01:44 +00:00
contrib TrivialRebase: Replace category_id with label 2013-07-29 16:12:32 +00:00
Documentation Merge branch 'stable-2.6' into stable-2.7 2013-08-12 19:29:41 -07:00
gerrit-acceptance-tests Fix change stuck in SUBMITTED state but actually merged 2013-09-18 17:01:44 +00:00
gerrit-antlr Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-cache-h2 Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-common Merge branch 'stable-2.6' into stable-2.7 2013-08-06 11:33:27 -07:00
gerrit-extension-api Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-gwtdebug Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-gwtexpui Update Eclipse prefs for gwtexpui to use Google code formatter 2013-04-16 10:02:23 +09:00
gerrit-gwtui Merge branch 'stable-2.6' into stable-2.7 2013-08-29 18:20:03 +09:00
gerrit-httpd Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-launcher Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-main Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-openid Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-patch-commonsnet Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-patch-jgit Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-pgm Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-plugin-api Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-plugin-archetype Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-plugin-gwt-archetype Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-plugin-gwtui Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-plugin-js-archetype Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-prettify Merge branch 'stable-2.6' into stable-2.7 2013-07-05 18:55:24 -07:00
gerrit-reviewdb Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-server Fix change stuck in SUBMITTED state but actually merged 2013-09-18 17:01:44 +00:00
gerrit-sshd Merge branch 'stable-2.6' into stable-2.7 2013-08-31 18:14:56 -07:00
gerrit-util-cli Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-util-ssl Gerrit 2.6 2013-06-21 09:51:01 -07:00
gerrit-war Merge branch 'stable-2.6' into stable-2.7 2013-08-12 11:57:16 -07:00
plugins Gerrit 2.6 2013-06-21 09:51:01 -07:00
ReleaseNotes Merge branch 'stable-2.6' into stable-2.7 2013-08-06 11:33:27 -07:00
tools Fix test skipping flag 2013-07-25 20:26:38 +03:00
.gitignore Adding sublime project files to .gitignore 2012-11-02 10:20:21 -04:00
.gitmodules Reference included plugins by absolute Urls 2013-05-18 17:59:28 +02:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
pom.xml Add plugin repositories section in the pom 2013-07-02 11:30:38 +03:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00