f873c21133
Users of the CC entry in the reply dialog expect a GMail-like workflow in which a text entry that had not been submitted via the autocomplete would still be added as a CC entry. With this change, text values in the CC field are submitted as entries when 'Send' or 'Save' is pressed. If the entry is an invalid email, the standard toast is shown and the action is blocked. Also adds an integration test suite for the reply-dialog with all relevant test boilerplate copied from the standard reply-dialog_test suite. Bug: Issue 6194 Change-Id: I1e7aa97b1847ea2409136dfdc7e9f760e22cdbf5
120 lines
3.4 KiB
HTML
120 lines
3.4 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
Copyright (C) 2015 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-reply-dialog</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
|
|
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
|
|
<link rel="import" href="gr-reply-dialog.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-reply-dialog></gr-reply-dialog>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-reply-dialog tests', () => {
|
|
let element;
|
|
let changeNum;
|
|
let patchNum;
|
|
|
|
let sandbox;
|
|
|
|
setup(() => {
|
|
sandbox = sinon.sandbox.create();
|
|
|
|
changeNum = 42;
|
|
patchNum = 1;
|
|
|
|
stub('gr-rest-api-interface', {
|
|
getConfig() { return Promise.resolve({}); },
|
|
getAccount() { return Promise.resolve({}); },
|
|
});
|
|
|
|
element = fixture('basic');
|
|
element.change = {
|
|
_number: changeNum,
|
|
labels: {
|
|
'Verified': {
|
|
values: {
|
|
'-1': 'Fails',
|
|
' 0': 'No score',
|
|
'+1': 'Verified',
|
|
},
|
|
default_value: 0,
|
|
},
|
|
'Code-Review': {
|
|
values: {
|
|
'-2': 'Do not submit',
|
|
'-1': 'I would prefer that you didn\'t submit this',
|
|
' 0': 'No score',
|
|
'+1': 'Looks good to me, but someone else must approve',
|
|
'+2': 'Looks good to me, approved',
|
|
},
|
|
default_value: 0,
|
|
},
|
|
},
|
|
};
|
|
element.patchNum = patchNum;
|
|
element.permittedLabels = {
|
|
'Code-Review': [
|
|
'-1',
|
|
' 0',
|
|
'+1',
|
|
],
|
|
'Verified': [
|
|
'-1',
|
|
' 0',
|
|
'+1',
|
|
],
|
|
};
|
|
element.serverConfig = {note_db_enabled: true};
|
|
|
|
sandbox.stub(element, 'fetchIsLatestKnown', () => Promise.resolve(true));
|
|
|
|
// Allow the elements created by dom-repeat to be stamped.
|
|
flushAsynchronousOperations();
|
|
});
|
|
|
|
teardown(() => {
|
|
sandbox.restore();
|
|
});
|
|
|
|
test('send blocked when invalid email is supplied to ccs', () => {
|
|
const sendStub = sandbox.stub(element, 'send').returns(Promise.resolve());
|
|
// Stub the below function to avoid side effects from the send promise
|
|
// resolving.
|
|
sandbox.stub(element, '_purgeReviewersPendingRemove');
|
|
|
|
element.$$('#ccs').$.entry.setText('test');
|
|
MockInteractions.tap(element.$$('gr-button.send'));
|
|
assert.isFalse(sendStub.called);
|
|
flushAsynchronousOperations();
|
|
|
|
element.$$('#ccs').$.entry.setText('test@test.test');
|
|
MockInteractions.tap(element.$$('gr-button.send'));
|
|
assert.isTrue(sendStub.called);
|
|
});
|
|
});
|
|
</script>
|