Files
gerrit/java/com
Thomas Draebing 773777e613 Respect log.textLogging and log.jsonLogging using --console-log
The gerrit.war daemon provides a --console-log flag to send the
error logs to stderr. However, when using this flag, no logs were
written to the error_log or error_log.json files, even if the
corresponding option, log.textLogging or log.jsonLogging, was set
in the gerrit.config file.

On the one hand, the configuration should be respected and on the
other hand, there are usecases, where both output channels are
useful. Mainly, if Gerrit is run in a docker container, it is
useful to be able to use 'docker logs' to view the current logs
and to have the logs persisted at the same time. While one can
tail the log-file to do so, Gerrit is then not the main process
of the container and will thus not be gracefully shutdown, when
stopping the container. Use the --console-log option together
with {text|json}Logging to log to stderr and the error_log file
without the need to tail the file to stdout.

Note, that this will as a side effect change the default behaviour
of the --console-log flag. Since the log.textLogging option
is true by default, using the --console-log flag will now by
default log to stderr and the error_log file. This can be
prevented by setting log.textLogging to 'false'.

Bug: Issue 13184
Change-Id: I5c3dfa531a6ccd397d3ceb60defc6e83943e95f1
2020-07-31 14:31:07 +00:00
..