6724990a32
With the introduction of default methods in Java 8, Java finally grew a List#sort method that can be used in place of the static Collections#sort. Convert simple in-place sorts that need to be in-place sorts to use this method where possible. During the course of this change, it became obvious that many instances of sort were just sorting a newly-created ArrayList in place. These can be replaced with more idiomatic Stream constructions, sometimes even eliminating a loop to populate the list. One difference between List#sort and Collections#sort is there is no List#sort() with no arguments; callers must always pass either naturalOrder() or a null comparators. In this change, there were so few remaining instances of sorting by natural order that typing naturalOrder() didn't seem too repetitious, and it is quite readable. Change-Id: I4d89421a72127e9a36cbd32aeac425c0471a1b3f
74 lines
2.2 KiB
Java
74 lines
2.2 KiB
Java
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server.patch;
|
|
|
|
import com.google.gerrit.reviewdb.client.Patch;
|
|
import com.google.gerrit.reviewdb.client.Project;
|
|
import com.google.inject.Inject;
|
|
import com.google.inject.assistedinject.Assisted;
|
|
import java.util.ArrayList;
|
|
import java.util.List;
|
|
import java.util.concurrent.Callable;
|
|
|
|
public class DiffSummaryLoader implements Callable<DiffSummary> {
|
|
public interface Factory {
|
|
DiffSummaryLoader create(DiffSummaryKey key, Project.NameKey project);
|
|
}
|
|
|
|
private final PatchListCache patchListCache;
|
|
private final DiffSummaryKey key;
|
|
private final Project.NameKey project;
|
|
|
|
@Inject
|
|
DiffSummaryLoader(PatchListCache plc, @Assisted DiffSummaryKey k, @Assisted Project.NameKey p) {
|
|
patchListCache = plc;
|
|
key = k;
|
|
project = p;
|
|
}
|
|
|
|
@Override
|
|
public DiffSummary call() throws Exception {
|
|
PatchList patchList = patchListCache.get(key.toPatchListKey(), project);
|
|
return toDiffSummary(patchList);
|
|
}
|
|
|
|
private DiffSummary toDiffSummary(PatchList patchList) {
|
|
List<String> r = new ArrayList<>(patchList.getPatches().size());
|
|
for (PatchListEntry e : patchList.getPatches()) {
|
|
if (Patch.isMagic(e.getNewName())) {
|
|
continue;
|
|
}
|
|
switch (e.getChangeType()) {
|
|
case ADDED:
|
|
case MODIFIED:
|
|
case DELETED:
|
|
case COPIED:
|
|
case REWRITE:
|
|
r.add(e.getNewName());
|
|
break;
|
|
|
|
case RENAMED:
|
|
r.add(e.getOldName());
|
|
r.add(e.getNewName());
|
|
break;
|
|
}
|
|
}
|
|
return new DiffSummary(
|
|
r.stream().sorted().toArray(String[]::new),
|
|
patchList.getInsertions(),
|
|
patchList.getDeletions());
|
|
}
|
|
}
|