opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
10,063 Commits 1 Branch 360 Tags 120 MiB
7fcd202680
Go to file
David Pursehouse 7fcd202680 Buck: Fix infinite loop when trying to build non-existing core plugins 
Running `buck build plugins:core` before initialising the submodules
causes buck to throw FileNotFoundException and then go into an infinite
loop.

The genrule in the plugins' BUCK configuration has a check in the `cmd`
to make sure the required core plugins (`NEED`) exist, but it looks
like this gets evaluated after the `srcs` which is using `CORE`.

Change `srcs` to use `HAVE`.  Now buck will exit with an error when the
core plugins do not exist.

Bug: issue 2343
Change-Id: I1bc2f67bcf6aacfe553c00e54fff18f959ac4b79
2013-12-16 16:26:26 +09:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Recompression *.png images with pngout tool to reduce the size of files 2013-11-03 14:33:54 +00:00
Documentation Fix various spelling mistakes in the documentation 2013-12-16 14:50:04 +09:00
gerrit-acceptance-tests Merge branch 'stable-2.8' 2013-12-12 12:01:44 -08:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common Merge "Replace PatchDetailService saveDraft and deleteDraft" 2013-12-12 20:09:47 +00:00
gerrit-extension-api Include addReviewer in ChangeApi. 2013-12-04 13:56:05 -08:00
gerrit-gwtdebug Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-gwtexpui Fix border-radius on Firefox > 12 2013-12-14 03:43:04 +00:00
gerrit-gwtui Merge "Fix border-radius on Firefox > 12" 2013-12-16 06:41:58 +00:00
gerrit-httpd Merge "Replace PatchDetailService saveDraft and deleteDraft" 2013-12-12 20:09:47 +00:00
gerrit-launcher Replace 'indexOf()' expression with 'contains()' 2013-12-05 21:13:38 -07:00
gerrit-lucene Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Remove the use of + when using StringBuilder (1 of 2) 2013-12-08 19:59:00 -07:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-pgm Move "refs/..." constants to a RefNames class 2013-12-11 12:41:07 -08:00
gerrit-plugin-api Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-plugin-archetype Merge "Remove unused and outdated dependency to JUnit from plugin archetype" 2013-11-30 23:49:54 +00:00
gerrit-plugin-gwt-archetype Wait for UI plugins to load 2013-12-10 23:37:13 -08:00
gerrit-plugin-gwtui Wait for UI plugins to load 2013-12-10 23:37:13 -08:00
gerrit-plugin-js-archetype Merge "Update .settings files in Maven archetypes" 2013-11-30 21:23:46 +00:00
gerrit-prettify Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-reviewdb Move "refs/..." constants to a RefNames class 2013-12-11 12:41:07 -08:00
gerrit-server Merge changes Ia439a16c,I5d4af103 2013-12-14 01:02:09 +00:00
gerrit-solr Fix last line of license headers 2013-10-14 17:40:17 +00:00
gerrit-sshd CreateBranchCommand: remove unused imports 2013-12-13 12:31:04 -08:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Fix WebAppInitializer when sshd.listenAddress=off and host key doesn't exist 2013-12-06 14:11:40 +01:00
lib Update gwtjsonrpc to 1.4 2013-12-12 16:25:48 +09:00
plugins Buck: Fix infinite loop when trying to build non-existing core plugins 2013-12-16 16:26:26 +09:00
ReleaseNotes Mention gwtorm and gwtjsonrpc updates in 2.9 release notes 2013-12-12 19:20:47 +09:00
tools Buck: fix api_install rule 2013-12-06 19:12:12 +01:00
website/releases Update release website index to use new documentation site 2013-10-17 17:07:30 +09:00
.buckconfig Cache buck build results locally by default 2013-12-11 13:21:39 +01:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Update Buck 2013-11-29 10:50:59 -08:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Buck: generate javadocs for plugin and extension API 2013-11-24 02:04:51 +01:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Update VERSION file to 2.9-SNAPSHOT 2013-10-17 23:09:00 +09:00