David Ostrovsky 8083f174ab Submit: Fix ClassCastException for anonymous user ... Change screen is using GET /changes/<iid>/revisions/<id>/actions REST endpoint, that is always returning empty map for anonymous user. In this code path UI action handlers don't get called, and getDescription() methods from UI action classes aren't invoked. However for unified change screen, the old code path in RPC code is still active and calling PatchSetDetailFactory.call() and there UiActions.sorted() is invoked, that iterates over all UI actions and invokes getDescription() methods to figure out if this UI action should be rendered or not. However, since I7ec4a0beb5 all this code is dead and it was a mistake not to remove it, because only there actions were rendered and not on the old unified diff. That why we can safely remove all this code and prevent that getDescription() methods from UI actions classes get called for the anonymous users (and registered users) in the first place. Eclipse-Bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=479618 Bug: Issue 3531 Change-Id: I5480f0922cfe9a778472a3c99fd5631b3e5f2474		2015-10-14 00:54:55 +02:00
..
src	Submit: Fix ClassCastException for anonymous user	2015-10-14 00:54:55 +02:00
BUCK	Support AutoValue	2014-11-08 08:31:08 -08:00