opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
10,227 Commits 1 Branch 360 Tags 120 MiB
86d070f83e
Go to file
Dave Borowitz 86d070f83e Eliminate potential NPEs with ChangeData.getChange() 
Callers were supposed to be calling hasChange() to determine whether
getChange() would return null, but none were. Remove this error-prone
pair of methods and just use change(), which includes lazy loading.
There are a few places where we need to catch an additional
OrmException but these are easy enough to fix.

Change-Id: I23335e362715f59e2c093ffec88427739ff0cffc
2014-01-03 09:10:45 -08:00
.settings Eclipse: Bump java source and target level to 7 2013-11-29 00:15:50 +01:00
contrib Add contrib/ui-api-proxy.go for testing UI features with live data. 2013-12-18 09:07:02 -08:00
Documentation Merge "Include modified B side lines when whitespace is ignored" 2014-01-03 15:56:25 +00:00
gerrit-acceptance-tests Use only loopback addresses in acceptance tests 2013-12-30 10:39:16 -08:00
gerrit-antlr Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-cache-h2 Merge "Remove unused @SuppressWarnings" 2013-11-29 08:08:53 +00:00
gerrit-common Fix race conditions in LabelTypes map creation 2014-01-02 15:58:39 -08:00
gerrit-extension-api Add MessageOfTheDay extension point for plugins 2014-01-02 08:19:57 -08:00
gerrit-gwtdebug Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-gwtexpui Fix border-radius on Firefox > 12 2013-12-14 03:43:04 +00:00
gerrit-gwtui Defer handling onSuccess for large REST payloads 2014-01-03 08:45:32 -08:00
gerrit-httpd Add MessageOfTheDay extension point for plugins 2014-01-02 08:19:57 -08:00
gerrit-launcher Use try/multi-catch for some reflection-related exceptions 2013-12-27 13:02:28 -08:00
gerrit-lucene Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-openid Remove the use of + when using StringBuilder (1 of 2) 2013-12-08 19:59:00 -07:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-pgm Merge "Add init step for installing the 'Verified' label" 2013-12-22 18:07:47 +00:00
gerrit-plugin-api Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-plugin-archetype Merge "Remove unused and outdated dependency to JUnit from plugin archetype" 2013-11-30 23:49:54 +00:00
gerrit-plugin-gwt-archetype Wait for UI plugins to load 2013-12-10 23:37:13 -08:00
gerrit-plugin-gwtui Wait for UI plugins to load 2013-12-10 23:37:13 -08:00
gerrit-plugin-js-archetype Merge "Update .settings files in Maven archetypes" 2013-11-30 21:23:46 +00:00
gerrit-prettify Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-reviewdb SideBySide2: Add preference to hide line numbers 2013-12-13 09:11:38 -08:00
gerrit-server Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-solr Eliminate potential NPEs with ChangeData.getChange() 2014-01-03 09:10:45 -08:00
gerrit-sshd Use REST endpoint to create project in SSH create-project command 2013-12-30 08:08:20 -08:00
gerrit-util-cli Save GWT compile time by avoiding javac 2013-11-30 11:06:50 -08:00
gerrit-util-ssl Remove unused .gitignore 2013-11-28 22:56:51 -08:00
gerrit-war Fix WebAppInitializer when sshd.listenAddress=off and host key doesn't exist 2013-12-06 14:11:40 +01:00
lib Merge "Update org.pegdown:pegdown to 1.2.1" 2014-01-02 09:40:00 +00:00
plugins Move more functionality from elsewhere into ApprovalsUtil 2013-12-19 10:30:56 -08:00
ReleaseNotes Mention gwtorm and gwtjsonrpc updates in 2.9 release notes 2013-12-12 19:20:47 +09:00
tools Merge "Buck: Add support for non transitive plugin dependencies" 2013-12-18 00:02:54 +00:00
website/releases Update release website index to use new documentation site 2013-10-17 17:07:30 +09:00
.buckconfig Cache buck build results locally by default 2013-12-11 13:21:39 +01:00
.buckversion Update Buck 2013-11-29 10:50:59 -08:00
.gitignore Update Buck 2013-11-29 10:50:59 -08:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.pydevproject Set python version back to 2.6.5 in .pydevproject 2013-05-20 11:36:08 +09:00
BUCK Buck: generate javadocs for plugin and extension API 2013-11-24 02:04:51 +01:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Update VERSION file to 2.9-SNAPSHOT 2013-10-17 23:09:00 +09:00