opendev/gerrit

History

Becky Siegel 8bb09344ab Don't display tooltips on touch devices Previously on iOS devices, tooltips in reply dialog did not always close when clicking outside of the button. The focusOut event was not triggered and thus _handleHideTooltip was not called. On other devices, the tooltip remained open when clicking on it. This change detects when a device triggers a touch event and sets a boolean variable that it is a touch device. If touch, we do not open and close tooltips. This was necessary because mouseenter and mouseleave events are still triggered on touch devices with a touch. Also, mouseover and mouseout events were replaced with mousenter and mouseleave events because it seemed better practice since they don't bubble to child elements & this is what is done in paper-tooltip. Bug: Issue 4649 Change-Id: Ib3a4681e8da77a5cd7c140e3a899ceb0cf8400a8		2016-10-18 18:10:10 -07:00
..
app	Don't display tooltips on touch devices	2016-10-18 18:10:10 -07:00
.gitattributes	Add the skeleton of a new UI based on Polymer, PolyGerrit	2015-11-09 22:01:28 +00:00
.gitignore	Serve fonts from Gerrit instead of Google Fonts.	2016-04-01 13:11:02 -04:00
BUCK	Add es6-promise for Internet Explorer	2016-09-13 15:14:32 +00:00
BUILD	bazel: add rules for vulcanize & crisper, and use them in //polygerrit-ui/app.	2016-10-06 14:01:05 +02:00
README.md	A tiny fix to the polygerrit ui README	2016-10-10 16:06:45 -07:00
run-server.sh	Serve fonts from Gerrit instead of Google Fonts.	2016-04-01 13:11:02 -04:00
server.go	Return correct error code from accounts/self/detail in test server	2016-05-06 12:41:33 -04:00
wct.conf.js	Add the skeleton of a new UI based on Polymer, PolyGerrit	2015-11-09 22:01:28 +00:00

README.md

PolyGerrit

Installing Node.js

# Debian/Ubuntu
sudo apt-get install nodejs-legacy

# OS X with Homebrew
brew install node

All other platforms: download from nodejs.org.

Installing Buck

Follow the instructions here to get and install Buck.

Local UI, Production Data

This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.

Installing go

This is required for running the run-server.sh script below.

# Debian/Ubuntu
sudo apt-get install golang

# OS X with Homebrew
brew install go

All other platforms: download from golang.org

Then add go to your path:

PATH=$PATH:/usr/local/go/bin

Running the server

To test the local UI against gerrit-review.googlesource.com:

./run-server.sh

Then visit http://localhost:8081

Local UI, Test Data

One-time setup:

Build Gerrit
Set up a local test site. Docs here and here.

When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:

buck build polygerrit && \
java -jar buck-out/gen/polygerrit/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace

Running Tests

One-time setup:

# Debian/Ubuntu
sudo apt-get install npm

# OS X with Homebrew
brew install npm

# All platforms (including those above)
sudo npm install -g web-component-tester

Run all web tests:

buck test --no-results-cache --include web

The --no-results-cache flag prevents flaky test failures from being cached.

If you need to pass additional arguments to wct:

WCT_ARGS='-p --some-flag="foo bar"' buck test --no-results-cache --include web

For interactively working on a single test file, do the following:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081/elements/foo/bar_test.html

Style guide

We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.