Dave Borowitz
8bd35ec888
Merge changes from topic "remove-schema-factory"
* changes:
So long, SchemaFactory!
Stop exposing SchemaFactory to plugins
Update replication plugin to remove ReviewDb usage
Remove SchemaFactory from ManualRequestContext
Remove PerThreadReviewDbModule
BaseInit: Remove SchemaFactory
SshScope: Remove SchemaFactory
AbstractDaemonTest: Remove SchemaFactory and db
Remove SchemaFactory from InProcessProtocol
Remove SchemaFactory from AcceptanceTestRequestScope
ChangeEditIT: Remove SchemaFactory
AbstractChangeNotesTest: Remove unused ReviewDb bindings
AllChangesIndexer: Remove SchemaFactory
BecomeAnyAccountLoginServlet: Remove SchemaFactory
Remove InMemoryDatabase
Extract SchemaCreator#ensureCreated() method
Remove getReviewDbProvider() from RequestContext interface
Remove ReviewDb from ChangeKindCache interface
Remove unused ReviewDb from SuggestReviewers hierarchy
Remove ReviewDb from EmailArguments
Remove ReviewDbUtil class
Remove outdated NotesMigrationSchemaFactory comments
Remove unused BatchUpdateReviewDb class
Remove ReviewDb-specific Mergeable#invalidateETag method
Remove ReviewDbUtil#intKeyOrdering()
Remove SQL-only QueryShell
Remove ReviewDb from AbstractChangeNotes.Args
Remove ReviewDb from AccountQueryBuilder.Arguments
Remove ReviewDb from ChangeQueryBuilder.Arguments
Remove ReviewDb args from merge code
Remove ReviewDb argument from BatchUpdate.Factory
Remove now-unused Context#getDb() method
Remove direct no-op ReviewDb updates via Context#getDb()
Remove ReviewDb args from ApprovalsUtil
Remove ReviewDb from PermissionBackend hierarchy
Remove ReviewDb from ChangeData
Remove StoredValues.REVIEW_DB
Clean up unused argument warnings
ChangeNotesState: Remove unused exception
ApprovalsUtil: Remove unused sortApprovals method