8d3885d357
This replaces the manual threadpool management in ReceiveCommits with a more general approach. That support was added for slow NoSQL backends, which may also have poor performance characteristics when updating lots of NoteDb refs in parallel. This approach substantially rewrites the BatchUpdate loop to stage all NoteDb update operations in memory in separate threads, each with its own copy of the ReviewDb and change repo, and then aggregates the results together in the main thread with a single ObjectInserter and BatchRefUpdate. One nice thing about this approach is it doesn't require any changes to BatchUpdate.Op implementations: each Op's methods are executed sequentially, in one thread at a time, with proper barriers (an executor) to ensure later methods see the results of writes in the background thread. Use an in-memory implementation of ObjectInserter in each of the background threads' NoteDbUpdateManagers to buffer writes completely in memory until it's time for the caller to flush. This wastes a small amount of memory for the buffer, but these are just NoteDb objects, so they should be quite small. This implementation using immutable result types is preferable to trying to share a Repository/ObjectReader/ ObjectInserter across threads, which requires manual locking. That is not only painful but also produces deadlocks when mixing repo-level locks and SQL-level locks (e.g. H2's transaction implementation) across threads. Change-Id: I40545a4d48fcfa892bd3e4c0cd9b72ab7fac9436
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.