Files
gerrit/polygerrit-ui/app/elements/shared/gr-linked-text/gr-linked-text.js
Becky Siegel dfacebd899 Remove zero space char from linkify
In a previous change, a zero space char was added in order for linkify
to not link R= as part of am email address. At the time, we concluded
that a zero width space would not be an issue for users. After receiving
a complaint, this change removes the added zero width space after
linkificataion.

Because the space has to get removed in the linked text parser, an
optional parameter is added to gr-linked-text indicating that this
removal will need to take place. Because it is only needed in the commit
message, this avoids doing the replacement search for all other linked
text areas.

Bug: Issue 5339
Change-Id: I3d7b29106cafab61193e6fb65225fc3325104756
2017-02-02 12:58:12 -08:00

71 lines
2.0 KiB
JavaScript

// Copyright (C) 2016 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
(function() {
'use strict';
Polymer({
is: 'gr-linked-text',
properties: {
removeZeroWidthSpace: Boolean,
content: {
type: String,
observer: '_contentChanged',
},
pre: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
disabled: {
type: Boolean,
value: false,
reflectToAttribute: true,
},
config: Object,
},
observers: [
'_contentOrConfigChanged(content, config)',
],
_contentChanged: function(content) {
// In the case where the config may not be set (perhaps due to the
// request for it still being in flight), set the content anyway to
// prevent waiting on the config to display the text.
if (this.config != null) { return; }
this.$.output.textContent = content;
},
_contentOrConfigChanged: function(content, config) {
var output = Polymer.dom(this.$.output);
output.textContent = '';
var parser = new GrLinkTextParser(
config, function(text, href, fragment) {
if (href) {
var a = document.createElement('a');
a.href = href;
a.textContent = text;
a.target = '_blank';
a.rel = 'noopener';
output.appendChild(a);
} else if (fragment) {
output.appendChild(fragment);
}
}, this.removeZeroWidthSpace);
parser.parse(content);
},
});
})();