Until now, we needed the transformation logic only for identifying edits due to rebase. Ported comments (I4e96af5ac) will need the same basic algorithm, though, which we don't want to duplicate. There are still some differences (e.g. ported comments requiring comment locations to be transformed and not diff edits) because of which we need a more generalized version. We already account for some of these differences in this change. Further adjustments (e.g. explicit support and handling of deleted files; not-existing ranges) will be done in further changes. Extracting the logic will also allow us to add detailed unit tests for it. Arguably, we could have already had unit tests for EditTransformer. However, construction of all the JGit based inputs like PatchListEntry (which requires a properly filled FileHeader from JGit, which requires further properly filled JGit objects) is hairy. Adding unit tests for GitPositionTransformer is deferred to a later time, though. Even without these tests, we should notice any errors which could be potentially introduced by this change through the extensive tests for edits due to rebase. Change-Id: I4062e6a2274ea71f862ac132421b67826091fc56
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Use pre-built Gerrit images on Docker
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.