5174d2d95e
String.split(String) has surprising behaviour [1]:
String[] nothing = "".split(":"); // results in [""]
String[] bunchOfNothing = ":".split(":"); // results in []
More examples:
input | input.split(":") | Splitter.on(':').split(input)
=======|===================|==============================
"" | [""] | [""]
":" | [] | ["", ""]
":::" | [] | ["", "", "", ""]
"a:::" | ["a"] | ["a", "", "", ""]
":::b" | ["", "", "", "b"] | ["", "", "", "b"]
In addition using Splitter makes the code more readable as Splitter has
nicer methods that make it clearer which high-level operation should be
performed. E.g. in some places we can use
Splitter.on(CharMatcher.anyOf(something)) instead of matching on
patterns.
Tests and classes that are used by the GWT UI are not adapted.
[1] http://konigsberg.blogspot.com/2009/11/final-thoughts-java-puzzler-splitting.html
Change-Id: I6f141fb492e2fb94544089d794f245d0885f8649
Signed-off-by: Edwin Kempin <ekempin@google.com>
80 lines
2.9 KiB
Java
80 lines
2.9 KiB
Java
// Copyright (C) 2012 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server.args4j;
|
|
|
|
import com.google.common.base.Splitter;
|
|
import com.google.gerrit.reviewdb.client.Branch;
|
|
import com.google.gerrit.reviewdb.client.Change;
|
|
import com.google.gerrit.reviewdb.client.Project;
|
|
import com.google.gerrit.server.query.change.ChangeData;
|
|
import com.google.gerrit.server.query.change.InternalChangeQuery;
|
|
import com.google.gwtorm.server.OrmException;
|
|
import com.google.inject.Inject;
|
|
import com.google.inject.Provider;
|
|
import com.google.inject.assistedinject.Assisted;
|
|
import java.util.List;
|
|
import org.kohsuke.args4j.CmdLineException;
|
|
import org.kohsuke.args4j.CmdLineParser;
|
|
import org.kohsuke.args4j.OptionDef;
|
|
import org.kohsuke.args4j.spi.OptionHandler;
|
|
import org.kohsuke.args4j.spi.Parameters;
|
|
import org.kohsuke.args4j.spi.Setter;
|
|
|
|
public class ChangeIdHandler extends OptionHandler<Change.Id> {
|
|
private final Provider<InternalChangeQuery> queryProvider;
|
|
|
|
@Inject
|
|
public ChangeIdHandler(
|
|
// TODO(dborowitz): Not sure whether this is injectable here.
|
|
Provider<InternalChangeQuery> queryProvider,
|
|
@Assisted final CmdLineParser parser,
|
|
@Assisted final OptionDef option,
|
|
@Assisted final Setter<Change.Id> setter) {
|
|
super(parser, option, setter);
|
|
this.queryProvider = queryProvider;
|
|
}
|
|
|
|
@Override
|
|
public final int parseArguments(Parameters params) throws CmdLineException {
|
|
final String token = params.getParameter(0);
|
|
final List<String> tokens = Splitter.on(',').splitToList(token);
|
|
if (tokens.size() != 3) {
|
|
throw new CmdLineException(
|
|
owner, "change should be specified as <project>,<branch>,<change-id>");
|
|
}
|
|
|
|
try {
|
|
final Change.Key key = Change.Key.parse(tokens.get(2));
|
|
final Project.NameKey project = new Project.NameKey(tokens.get(0));
|
|
final Branch.NameKey branch = new Branch.NameKey(project, tokens.get(1));
|
|
for (ChangeData cd : queryProvider.get().byBranchKey(branch, key)) {
|
|
setter.addValue(cd.getId());
|
|
return 1;
|
|
}
|
|
} catch (IllegalArgumentException e) {
|
|
throw new CmdLineException(owner, "Change-Id is not valid");
|
|
} catch (OrmException e) {
|
|
throw new CmdLineException(owner, "Database error: " + e.getMessage());
|
|
}
|
|
|
|
throw new CmdLineException(owner, "\"" + token + "\": change not found");
|
|
}
|
|
|
|
@Override
|
|
public final String getDefaultMetaVariable() {
|
|
return "CHANGE";
|
|
}
|
|
}
|