Wyatt Allen ffae724134 Save diff mode preference when toggled
Introduce the gr-diff-mode-selector which componentizes the diff mode
buttons already used in the file list and adds them to the diff view.
With this new component, when authenticated users change their diff
preference using the new selector (or by the 'm' keyboard shortcut), the
new mode is saved to their preferences. Unauthenticated users see no
change in diff mode preference persistence.

The diff selector is now consistently labeled as "Diff view" rather than
as "Diff views".

Bug: Issue 8144
Change-Id: I4b30714deb9a466e707b3d4ae90c1d4c60222c64
2018-02-15 11:43:10 -08:00

85 lines
2.6 KiB
HTML

<!DOCTYPE html>
<!--
Copyright (C) 2018 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
<title>gr-diff-mode-selector</title>
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
<script src="../../../bower_components/web-component-tester/browser.js"></script>
<link rel="import" href="../../../test/common-test-setup.html"/>
<script src="../../../bower_components/page/page.js"></script>
<script src="../../../scripts/util.js"></script>
<link rel="import" href="gr-diff-mode-selector.html">
<script>void(0);</script>
<test-fixture id="basic">
<template>
<gr-diff-mode-selector></gr-diff-mode-selector>
</template>
</test-fixture>
<script>
suite('gr-diff-mode-selector tests', () => {
let element;
let sandbox;
setup(() => {
sandbox = sinon.sandbox.create();
element = fixture('basic');
});
teardown(() => {
sandbox.restore();
});
test('_computeSelectedClass', () => {
assert.equal(
element._computeSelectedClass('SIDE_BY_SIDE', 'SIDE_BY_SIDE'),
'selected');
assert.equal(
element._computeSelectedClass('SIDE_BY_SIDE', 'UNIFIED_DIFF'), '');
});
test('setMode', () => {
const saveStub = sandbox.stub(element.$.restAPI, 'savePreferences');
// Setting the mode initially does not save prefs.
element.saveOnChange = true;
element.setMode('SIDE_BY_SIDE');
assert.isFalse(saveStub.called);
// Setting the mode to itself does not save prefs.
element.setMode('SIDE_BY_SIDE');
assert.isFalse(saveStub.called);
// Setting the mode to something else does not save prefs if saveOnChange
// is false.
element.saveOnChange = false;
element.setMode('UNIFIED_DIFF');
assert.isFalse(saveStub.called);
// Setting the mode to something else does not save prefs if saveOnChange
// is false.
element.saveOnChange = true;
element.setMode('SIDE_BY_SIDE');
assert.isTrue(saveStub.calledOnce);
});
});
</script>