9fa6264a1e
Based on the review comments from Ben Manes in [1], using Cache of locks is prone to races. Using Striped locks technique is a better technique for this use case. [1] https://gerrit-review.googlesource.com/145750 Bug: Issue 7903 Change-Id: I94868904befc0f0454ae518f79888a8473ad97c2
42 lines
1.4 KiB
Java
42 lines
1.4 KiB
Java
// Copyright (C) 2017 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server.project;
|
|
|
|
import com.google.common.util.concurrent.Striped;
|
|
import com.google.gerrit.extensions.registration.DynamicItem;
|
|
import com.google.gerrit.reviewdb.client.Project;
|
|
import com.google.inject.AbstractModule;
|
|
import com.google.inject.Singleton;
|
|
import java.util.concurrent.locks.Lock;
|
|
|
|
@Singleton
|
|
public class DefaultProjectNameLockManager implements ProjectNameLockManager {
|
|
|
|
public static class Module extends AbstractModule {
|
|
@Override
|
|
protected void configure() {
|
|
DynamicItem.bind(binder(), ProjectNameLockManager.class)
|
|
.to(DefaultProjectNameLockManager.class);
|
|
}
|
|
}
|
|
|
|
Striped<Lock> locks = Striped.lock(10);
|
|
|
|
@Override
|
|
public Lock getLock(Project.NameKey name) {
|
|
return locks.get(name);
|
|
}
|
|
}
|