Patrick Hiesel a3b587c0ce Make ProjectCache#get return an Optional<ProjectState> ...

This refactoring forces callers to think about how to handle projects
that do not exist explicitly. As a general guidance, API handlers will
want to throw a BadRequestException and components in the inner works of
Gerrit where content should have been pre-validated should throw an
IllegalStateException.

But overall, it's a case-by-case decision.

In a follow-up commit, we will remove #checkedGet and move callers to
get instead.

Change-Id: I95bbc22ad5f3279e6f40f1d05c8d7235d601e32d

2020-03-06 10:56:40 +01:00

..

Abandon.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

AllowedFormats.java

Move remaining REST handlers into restapi subpackage

2018-01-08 15:45:52 +01:00

ApplyFix.java

Merge branch 'stable-3.0' into stable-3.1

2020-01-16 11:30:38 +09:00

ChangeEdits.java

Merge branch 'stable-3.0' into stable-3.1

2020-01-16 11:30:38 +09:00

ChangeIncludedIn.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ChangeMessages.java

Fix exception handling when reading value from REST response

2019-09-18 11:54:37 +02:00

ChangesCollection.java

Merge branch 'stable-3.0' into stable-3.1

2020-03-01 17:21:02 +09:00

Check.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

CherryPick.java

Remove unneeded CherryPickChangeInfo class

2020-02-03 11:19:20 +01:00

CherryPickChange.java

Merge branch 'stable-3.0' into stable-3.1

2020-02-03 19:11:51 +09:00

CherryPickCommit.java

Remove unneeded CherryPickChangeInfo class

2020-02-03 11:19:20 +01:00

CommentJson.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

Comments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

CreateChange.java

CreateChange: only set 'author' when requested

2020-02-25 17:23:48 +01:00

CreateDraftComment.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

CreateMergePatchSet.java

CreateMergePatchSet: Do not fail with ISE if given merge strategy is invalid

2020-02-04 10:11:16 +09:00

DeleteAssignee.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteChange.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteChangeEdit.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

DeleteChangeMessage.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteComment.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteDraftComment.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeletePrivate.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeletePrivateByPost.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteReviewer.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DeleteVote.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

DownloadContent.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

DraftComments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

Files.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

Fixes.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetArchive.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetAssignee.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetBlame.java

Merge branch 'stable-3.0' into stable-3.1

2019-11-14 15:06:54 -08:00

GetChange.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

GetChangeMessage.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetComment.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetCommit.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetContent.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetDescription.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetDetail.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

GetDiff.java

Make ProjectCache#get return an Optional<ProjectState>

2020-03-06 10:56:40 +01:00

GetDraftComment.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetFixPreview.java

Make ProjectCache#get return an Optional<ProjectState>

2020-03-06 10:56:40 +01:00

GetHashtags.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

GetMergeList.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetPastAssignees.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

GetPatch.java

Merge branch 'stable-3.0' into stable-3.1

2020-02-21 15:22:07 -05:00

GetPureRevert.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetRelated.java

GetRelated: Add some debug logs

2019-12-20 14:38:59 +01:00

GetReview.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

GetReviewer.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetRevisionActions.java

Remove StorageException from throws clauses

2019-04-17 19:42:10 -07:00

GetRobotComment.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

GetTopic.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

Ignore.java

Response: Add ok() and created() helper methods

2019-11-01 11:22:45 +09:00

Index.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

ListChangeComments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListChangeDrafts.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListChangeMessages.java

Keep only AccountLoader.Factory in Singleton

2019-11-04 17:16:26 +00:00

ListChangeRobotComments.java

Require REST endpoints to return Response<?>

2019-08-05 15:35:47 +02:00

ListReviewers.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListRevisionComments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListRevisionDrafts.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListRevisionReviewers.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

ListRobotComments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

MarkAsReviewed.java

Response: Add ok() and created() helper methods

2019-11-01 11:22:45 +09:00

MarkAsUnreviewed.java

Response: Add ok() and created() helper methods

2019-11-01 11:22:45 +09:00

Mergeable.java

Make ProjectCache#get return an Optional<ProjectState>

2020-03-06 10:56:40 +01:00

Module.java

Add 'CherryPickOf' field for a change

2020-01-08 00:43:30 +00:00

Move.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PostHashtags.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PostPrivate.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PostReview.java

Merge branch 'stable-2.16' into stable-3.0

2020-02-19 14:23:45 -05:00

PostReviewers.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PreviewSubmit.java

Merge branch 'stable-3.0' into stable-3.1

2020-01-24 16:19:43 +09:00

PublishChangeEdit.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PutAssignee.java

Merge branch 'stable-3.1'

2020-01-24 19:46:26 +09:00

PutDescription.java

Include patch set number into message when setting description for patch set

2020-01-17 15:19:46 +01:00

PutDraftComment.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PutMessage.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

PutTopic.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

QueryChanges.java

Merge branch 'stable-3.1'

2020-01-24 19:46:26 +09:00

Rebase.java

Remove unused Response.InternalServerError and Response.traceId

2019-11-11 16:20:15 -08:00

RebaseChangeEdit.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

RelatedChangesSorter.java

RelatedChangesSorter#sort: Improve error message

2019-11-27 10:13:15 +01:00

Restore.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

Revert.java

Merge branch 'stable-3.0' into stable-3.1

2020-02-03 19:11:51 +09:00

RevertSubmission.java

Remove TODO comment that was already implemented

2020-02-24 13:10:45 +01:00

Reviewed.java

Response: Add ok() and created() helper methods

2019-11-01 11:22:45 +09:00

ReviewerRecommender.java

Merge branch 'stable-2.16' into stable-3.0

2020-02-19 14:23:45 -05:00

Reviewers.java

Ignore account visibility when parsing Reviewers Collection

2019-11-20 16:17:27 -08:00

ReviewersUtil.java

Migrate account index to use dimensional numeric types

2019-10-16 09:29:38 +00:00

RevisionReviewers.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

Revisions.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

RobotComments.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00

SetReadyForReview.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

SetWorkInProgress.java

Retry requests in RestApiServlet, no more retrying for Java API

2019-11-11 16:20:15 -08:00

Submit.java

Merge branch 'stable-3.1'

2020-01-24 19:46:26 +09:00

SubmittedTogether.java

Merge branch 'stable-3.0' into stable-3.1

2020-02-21 15:22:07 -05:00

SuggestChangeReviewers.java

Suggest Reviewers REST endpoint: Add option to suggest CCs

2019-08-27 11:55:54 +02:00

SuggestReviewers.java

Remove unused ReviewDb from SuggestReviewers hierarchy

2018-12-17 08:34:48 -08:00

TestSubmitRule.java

Make ProjectCache#get return an Optional<ProjectState>

2020-03-06 10:56:40 +01:00

TestSubmitType.java

SubmitRule: Remove SubmitRuleOptions arg from evaluate method

2019-08-12 09:21:53 +02:00

Unignore.java

Response: Add ok() and created() helper methods

2019-11-01 11:22:45 +09:00

Votes.java

Rename reviewdb package to entities and dissolve client package

2019-10-15 23:07:11 +02:00