b3cb869c16
Previously, there was an issue where the zero width space that was removed by linkify wasn't also removed by gr-editable-content. This meant that if a commit message with R= was edited, the zero-width space would be inserted in the actual commit message. This change removes the zero width space when editing the content in the same way that gr-linked-text does. Bug: Issue 5472 Change-Id: Ia115c7f57da0c81de5cd3c9e6a749922fe0a1ff9
84 lines
2.1 KiB
JavaScript
84 lines
2.1 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-editable-content',
|
|
|
|
/**
|
|
* Fired when the save button is pressed.
|
|
*
|
|
* @event editable-content-save
|
|
*/
|
|
|
|
/**
|
|
* Fired when the cancel button is pressed.
|
|
*
|
|
* @event editable-content-cancel
|
|
*/
|
|
|
|
properties: {
|
|
content: {
|
|
notify: true,
|
|
type: String,
|
|
},
|
|
disabled: {
|
|
reflectToAttribute: true,
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
editing: {
|
|
observer: '_editingChanged',
|
|
type: Boolean,
|
|
value: false,
|
|
},
|
|
removeZeroWidthSpace: Boolean,
|
|
_saveDisabled: {
|
|
computed: '_computeSaveDisabled(disabled, content, _newContent)',
|
|
type: Boolean,
|
|
value: true,
|
|
},
|
|
_newContent: String,
|
|
},
|
|
|
|
focusTextarea: function() {
|
|
this.$$('iron-autogrow-textarea').textarea.focus();
|
|
},
|
|
|
|
_editingChanged: function(editing) {
|
|
if (!editing) { return; }
|
|
|
|
// TODO(wyatta) switch linkify sequence, see issue 5526.
|
|
this._newContent = this.removeZeroWidthSpace ?
|
|
this.content.replace(/^R=\u200B/gm, 'R=') : this.content;
|
|
},
|
|
|
|
_computeSaveDisabled: function(disabled, content, newContent) {
|
|
return disabled || (content === newContent);
|
|
},
|
|
|
|
_handleSave: function(e) {
|
|
e.preventDefault();
|
|
this.fire('editable-content-save', {content: this._newContent});
|
|
},
|
|
|
|
_handleCancel: function(e) {
|
|
e.preventDefault();
|
|
this.editing = false;
|
|
this.fire('editable-content-cancel');
|
|
},
|
|
});
|
|
})();
|