aae6d670a5
There was an issue with gr-select that when the bound value is 0, the native value was not set properly because of the way the value was checked. This change fixes the issue by explicitly checking for undefined rather than falsy value. Change-Id: I1ef33cdb99933e5d2a8ba1fd9360266e8d258eaf
60 lines
1.7 KiB
JavaScript
60 lines
1.7 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
Polymer({
|
|
is: 'gr-select',
|
|
properties: {
|
|
bindValue: {
|
|
type: String,
|
|
notify: true,
|
|
observer: '_updateValue',
|
|
},
|
|
},
|
|
|
|
listeners: {
|
|
'change': '_valueChanged',
|
|
'dom-change': '_updateValue',
|
|
},
|
|
|
|
get nativeSelect() {
|
|
return this.$$('select');
|
|
},
|
|
|
|
_updateValue() {
|
|
// It's possible to have a value of 0.
|
|
if (this.bindValue !== undefined) {
|
|
// Set for chrome/safari so it happens instantly
|
|
this.nativeSelect.value = this.bindValue;
|
|
// Async needed for firefox to populate value. It was trying to do it
|
|
// before options from a dom-repeat were rendered previously.
|
|
// See https://bugs.chromium.org/p/gerrit/issues/detail?id=7735
|
|
this.async(() => {
|
|
this.nativeSelect.value = this.bindValue;
|
|
}, 1);
|
|
}
|
|
},
|
|
|
|
_valueChanged() {
|
|
this.bindValue = this.nativeSelect.value;
|
|
},
|
|
|
|
ready() {
|
|
// If not set via the property, set bind-value to the element value.
|
|
if (!this.bindValue) { this.bindValue = this.nativeSelect.value; }
|
|
},
|
|
});
|
|
})();
|