Files
gerrit/polygerrit-ui/app/services
Dmitrii Filippov 7d4f2f3183 Update sinon version
The WCT tests used deprecated version on sinon. This change adds
the newest version of sinon to polygerrit and update tests.

Change-Id: Ic746c4afc97779974da643362e17c9c1bb1cbf48
2020-06-29 15:43:51 +02:00
..
2020-06-29 15:43:51 +02:00
2020-06-29 15:43:51 +02:00
2020-06-29 11:24:54 +02:00
2020-04-21 09:57:12 +02:00

What is services folder

'services' folder contains services used across multiple components.

What should be considered as services in Gerrit UI

Services should be stateful, if its just pure functions, consider having them in 'utils' instead.

Regarding all stateful should be considered as services or not, it's still TBD. Will update as soon as it's finalized.

How to access service

We use AppContext to access instance of service. It helps in mocking service in tests as well. We prefer setting instance of service in constructor and then accessing it from variable. We also allow access straight from appContext especially in static methods.

import {appContext} from '../../../services/app-context.js';

class T {
  constructor() {
    super();
    this.flagsService = appContext.flagsService;
  }

  action1() {
    if (this.flagsService.isEnabled('test)) {
      // do something
    }
  }
}

staticMethod() {
  if (appContext.flagsService.isEnabled('test)) {
    // do something
  }
}

What services we have

Flags

'flags' is a service to provide easy access to all enabled experiments.

import {appContext} from '../../../services/app-context.js';

// check if an experiment is enabled or not
if (appContext.flagsService.isEnabled('test')) {
  // do something
}