History

Becky Siegel a88f8c82d4 Fix corner case where storage gets duplicated for patchsets

Previously, there was an issue where if you create a draft comment in
side by side view and switch to unified view, the comment thinks it's in
the later patch set rather than the earlier one and a second copy gets
added to local storage with the later patchset as a component of the
key.

This was because the the thread group assumed all threads inside of it
had the same patch number. This change fixes that, so in the event that
a user switches from side by side to unified, the patch number will get
taken from the comment rather than the thread group.

Bug: Issue 5493
Change-Id: I7f00997bcb2e6f1001a5d58ac206acf5af3367d2

2017-02-10 14:52:57 -08:00

app

Fix corner case where storage gets duplicated for patchsets

2017-02-10 14:52:57 -08:00

.gitattributes

Add the skeleton of a new UI based on Polymer, PolyGerrit

2015-11-09 22:01:28 +00:00

.gitignore

Serve fonts from Gerrit instead of Google Fonts.

2016-04-01 13:11:02 -04:00

BUILD

Bazel: Reformat build files

2016-12-07 11:33:07 +00:00

README.md

Fix polygerrit.war path when building PolyGerrit with Bazel

2017-01-23 14:38:00 -08:00

run-server.sh

Use test_components when running run-server.sh

2017-01-24 14:00:42 -08:00

server.go

Add CLI flag to run-server.go for local plugins

2017-02-09 09:09:27 -08:00

wct.conf.js

Add the skeleton of a new UI based on Polymer, PolyGerrit

2015-11-09 22:01:28 +00:00

README.md

PolyGerrit

Installing Node.js

# Debian/Ubuntu
sudo apt-get install nodejs-legacy

# OS X with Homebrew
brew install node

All other platforms: download from nodejs.org.

Installing Bazel

Follow the instructions here to get and install Bazel.

Local UI, Production Data

This is a quick and easy way to test your local changes against real data. Unfortunately, you can't sign in, so testing certain features will require you to use the "test data" technique described below.

Installing go

This is required for running the run-server.sh script below.

# Debian/Ubuntu
sudo apt-get install golang

# OS X with Homebrew
brew install go

All other platforms: download from golang.org

Then add go to your path:

PATH=$PATH:/usr/local/go/bin

Running the server

To test the local UI against gerrit-review.googlesource.com:

./run-server.sh

Then visit http://localhost:8081

Local UI, Test Data

One-time setup:

Build Gerrit
Set up a local test site. Docs here and here.

When your project is set up and works using the classic UI, run a test server that serves PolyGerrit:

bazel build polygerrit && \
java -jar bazel-bin/polygerrit.war daemon --polygerrit-dev \
-d ../gerrit_testsite --console-log --show-stack-trace

Running Tests

One-time setup:

# Debian/Ubuntu
sudo apt-get install npm

# OS X with Homebrew
brew install npm

# All platforms (including those above)
sudo npm install -g web-component-tester

Run all web tests:

./polygerrit-ui/app/run_test.sh

If you need to pass additional arguments to wct:

WCT_ARGS='-p --some-flag="foo bar"' ./polygerrit-ui/app/run_test.sh

For interactively working on a single test file, do the following:

./polygerrit-ui/run-server.sh

Then visit http://localhost:8081/elements/foo/bar_test.html

Style guide

We follow the Google JavaScript Style Guide with a few exceptions. When in doubt, remain consistent with the code around you.