There was a bug in the PUBLISH_ALL_REVISIONS case where we passed the
wrong PatchSet to PatchLineCommentsUtil.setCommentRevId, resulting in
saving comments on the wrong side. Add a checkArgument to
setCommentRevId that exposes this error, and fix it by passing the
right PatchSet object. This means we may have to look up additional
PatchSets for the change when writing to NoteDb. There is no way
around this: if we publish a comment for PS1 when posting a review
for PS2, we have not previously loaded PS1 to get the RevId, so we
need to do that now.
Test in CommentsIT for publishing comments on both sides
simultaneously.
Change-Id: Idbbc8d905a9e37ca6be9d45f8bddd0ca1fe0b248
dc86ab526e