Files
gerrit/java/com/google/gerrit/server/account/GroupControl.java
Alice Kober-Sotzek 656384bbef Allow admins to see all groups (including external ones) of a user
Previously, admins were only allowed to see the internal groups a user
belongs to. System groups as well as those from other GroupBackends were
excluded from the result. This impeded investigations in case of ACL
issues.

Allowing admins to see all groups shouldn't create a new security issue.
Even previously, admins had ways to track down any external groups which
were mentioned in Gerrit ACLs. If implemented correctly, external
GroupBackends should only provide groups which are mentioned in the
Gerrit ACLs of the corresponding project. In that case, listing all
groups for another user as admin shouldn't disclose any new information
to admins.

This change doesn't only allow admins to see all groups of a user but
also allows them to see all users who belong to an internal group even
when users are listed as members on subgroups. There is no apparent
reason to allow one direction without the other and that's why we don't
restrict it.

Change-Id: Ia71c59af6035ea23bad5a3156d1522f7dac6424b
2018-03-15 12:18:49 +01:00

183 lines
5.5 KiB
Java

// Copyright (C) 2009 The Android Open Source Project
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package com.google.gerrit.server.account;
import com.google.gerrit.common.data.GroupDescription;
import com.google.gerrit.common.errors.NoSuchGroupException;
import com.google.gerrit.extensions.restapi.AuthException;
import com.google.gerrit.reviewdb.client.Account;
import com.google.gerrit.reviewdb.client.AccountGroup;
import com.google.gerrit.server.CurrentUser;
import com.google.gerrit.server.permissions.GlobalPermission;
import com.google.gerrit.server.permissions.PermissionBackend;
import com.google.gerrit.server.permissions.PermissionBackendException;
import com.google.inject.Inject;
import com.google.inject.Provider;
import com.google.inject.Singleton;
/** Access control management for a group of accounts managed in Gerrit. */
public class GroupControl {
@Singleton
public static class GenericFactory {
private final PermissionBackend permissionBackend;
private final GroupBackend groupBackend;
@Inject
GenericFactory(PermissionBackend permissionBackend, GroupBackend gb) {
this.permissionBackend = permissionBackend;
groupBackend = gb;
}
public GroupControl controlFor(CurrentUser who, AccountGroup.UUID groupId)
throws NoSuchGroupException {
GroupDescription.Basic group = groupBackend.get(groupId);
if (group == null) {
throw new NoSuchGroupException(groupId);
}
return new GroupControl(who, group, permissionBackend, groupBackend);
}
}
public static class Factory {
private final PermissionBackend permissionBackend;
private final Provider<CurrentUser> user;
private final GroupBackend groupBackend;
@Inject
Factory(PermissionBackend permissionBackend, Provider<CurrentUser> cu, GroupBackend gb) {
this.permissionBackend = permissionBackend;
user = cu;
groupBackend = gb;
}
public GroupControl controlFor(AccountGroup.UUID groupId) throws NoSuchGroupException {
final GroupDescription.Basic group = groupBackend.get(groupId);
if (group == null) {
throw new NoSuchGroupException(groupId);
}
return controlFor(group);
}
public GroupControl controlFor(GroupDescription.Basic group) {
return new GroupControl(user.get(), group, permissionBackend, groupBackend);
}
public GroupControl validateFor(AccountGroup.UUID groupUUID) throws NoSuchGroupException {
final GroupControl c = controlFor(groupUUID);
if (!c.isVisible()) {
throw new NoSuchGroupException(groupUUID);
}
return c;
}
}
private final CurrentUser user;
private final GroupDescription.Basic group;
private Boolean isOwner;
private final PermissionBackend.WithUser perm;
private final GroupBackend groupBackend;
GroupControl(
CurrentUser who,
GroupDescription.Basic gd,
PermissionBackend permissionBackend,
GroupBackend gb) {
user = who;
group = gd;
this.perm = permissionBackend.user(user);
groupBackend = gb;
}
public GroupDescription.Basic getGroup() {
return group;
}
public CurrentUser getUser() {
return user;
}
/** Can this user see this group exists? */
public boolean isVisible() {
/* Check for canAdministrateServer may seem redundant, but allows
* for visibility of all groups that are not an internal group to
* server administrators.
*/
return user.isInternalUser()
|| groupBackend.isVisibleToAll(group.getGroupUUID())
|| user.getEffectiveGroups().contains(group.getGroupUUID())
|| isOwner()
|| canAdministrateServer();
}
public boolean isOwner() {
if (isOwner != null) {
return isOwner;
}
// Keep this logic in sync with VisibleRefFilter#isOwner(...).
if (group instanceof GroupDescription.Internal) {
AccountGroup.UUID ownerUUID = ((GroupDescription.Internal) group).getOwnerGroupUUID();
isOwner = getUser().getEffectiveGroups().contains(ownerUUID) || canAdministrateServer();
} else {
isOwner = false;
}
return isOwner;
}
private boolean canAdministrateServer() {
try {
perm.check(GlobalPermission.ADMINISTRATE_SERVER);
return true;
} catch (AuthException | PermissionBackendException denied) {
return false;
}
}
public boolean canAddMember() {
return isOwner();
}
public boolean canRemoveMember() {
return isOwner();
}
public boolean canSeeMember(Account.Id id) {
if (user.isIdentifiedUser() && user.getAccountId().equals(id)) {
return true;
}
return canSeeMembers();
}
public boolean canAddGroup() {
return isOwner();
}
public boolean canRemoveGroup() {
return isOwner();
}
public boolean canSeeGroup() {
return canSeeMembers();
}
private boolean canSeeMembers() {
if (group instanceof GroupDescription.Internal) {
return ((GroupDescription.Internal) group).isVisibleToAll() || isOwner();
}
return canAdministrateServer();
}
}