Dave Borowitz
ac56c313df
bazel: Recommend setting --action_env=PATH for local cache
...
The old configuration makes it impossible to compile Gerrit on Mac with
recent versions of Bazel. The flag --experimental_strict_action_env now
makes Bazel pass PATH=/bin:/usr/bin to subcommands. Building PolyGerrit
requires using node from $PATH. On Macs it is impossible (even for root)
to write to /usr/bin, so node has to live somewhere not in that
hard-coded PATH. I'm not sure when this behavior changed in Bazel; it
seems like it should have broken long ago. But it's marked experimental
so we can't complain too much.
The documentation of this option says:
If true, Bazel uses an environment with a static value for PATH and does
not inherit LD_LIBRARY_PATH or TMPDIR. Use --action_env=ENV_VARIABLE if you
want to inherit specific environment variables from the client, but note
that doing so can prevent cross-user caching if a shared cache is used.
Passing --action_env=PATH fixes the problem. I think it should be
safe(ish) to pass --action_env=PATH, since the particular setup
described in our docs is not used for cross-user caching. This may not
catch potential cache invalidations due to different versions of tools,
but I don't see how it's any worse than when the binaries in /usr/bin
get updated.
Change-Id: I94543bd4801b83a66ff150baf3fb9e12ded7555f
2018-04-16 12:05:39 +02:00
..
2016-05-17 23:23:31 +00:00
2015-05-06 11:25:51 -07:00
2018-03-17 10:08:39 +09:00
2017-10-31 11:02:37 -04:00
2017-08-28 01:44:52 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-07-06 10:54:42 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2018-03-10 01:01:35 +00:00
2017-08-08 14:24:34 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-07-20 09:50:05 -07:00
2016-07-07 14:06:31 +02:00
2017-02-24 11:10:22 +00:00
2018-03-27 20:21:29 +00:00
2017-04-14 08:45:12 +09:00
2016-07-06 10:54:42 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2017-08-28 01:44:52 +02:00
2017-08-28 01:44:52 +02:00
2017-08-28 01:44:52 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-09-06 16:27:49 +09:00
2016-07-06 10:54:42 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2017-08-28 01:44:52 +02:00
2017-08-28 01:44:52 +02:00
2016-07-07 14:06:31 +02:00
2018-02-21 09:25:21 +00:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2017-08-28 01:44:52 +02:00
2016-07-07 14:06:31 +02:00
2017-08-27 23:37:33 +00:00
2017-10-18 21:55:15 -04:00
2018-02-21 08:10:43 +01:00
2016-08-04 05:55:37 +00:00
2016-08-15 13:57:37 -07:00
2018-03-15 10:38:36 -04:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2016-07-07 14:06:31 +02:00
2017-08-28 01:44:52 +02:00
2017-08-09 18:56:03 -07:00
2017-08-09 19:07:02 -07:00
2017-08-09 19:02:17 -07:00
2018-01-18 14:35:21 +01:00
2017-03-01 08:18:24 +09:00
2016-08-22 17:46:31 +09:00
2018-04-12 10:20:10 +09:00
2018-03-16 09:47:32 +09:00
2017-12-05 15:57:58 +01:00
2016-07-04 11:06:18 +09:00
2018-03-27 09:47:23 +02:00
2017-07-04 21:20:47 +09:00
2018-03-22 16:30:08 +01:00
2018-03-15 15:02:58 +00:00
2018-01-09 14:37:08 +01:00
2015-07-06 01:50:38 +00:00
2016-09-28 15:34:54 +02:00
2018-02-02 13:39:59 +09:00
2016-07-07 14:06:31 +02:00
2017-03-03 15:54:53 +09:00
2017-10-11 06:37:47 +00:00
2018-04-16 12:05:39 +02:00
2018-02-27 17:06:26 +09:00
2017-10-20 22:06:15 +09:00
2018-02-02 10:13:45 +09:00
2017-12-21 18:05:43 +01:00
2016-07-08 14:07:44 +00:00
2017-03-03 10:12:14 +01:00
2018-03-12 16:59:25 +01:00
2018-02-15 21:11:55 +00:00
2018-02-02 10:13:45 +09:00
2017-06-30 13:38:33 +09:00
2016-08-31 11:13:47 +09:00
2018-02-07 09:16:41 -05:00
2017-10-12 09:46:46 +09:00
2017-02-28 09:09:33 +01:00
2017-10-01 12:38:18 +00:00
2014-05-02 17:21:22 +09:00
2014-05-02 17:21:22 +09:00
2014-09-04 13:12:24 +09:00
2014-09-04 13:12:24 +09:00
2013-12-20 12:55:51 -08:00
2014-03-11 18:24:13 +09:00
2013-12-20 12:55:51 -08:00
2016-07-08 13:45:28 +02:00
2013-12-20 12:55:51 -08:00
2014-05-02 17:21:22 +09:00
2014-07-08 07:24:01 +00:00
2018-01-26 09:06:16 +01:00
2014-09-04 13:12:24 +09:00
2014-02-21 09:25:33 +01:00
2014-05-02 17:21:22 +09:00
2013-12-20 12:55:51 -08:00
2018-01-26 08:49:52 +09:00
2013-12-20 12:55:51 -08:00
2013-12-20 12:55:51 -08:00
2013-12-20 12:55:51 -08:00
2013-12-20 12:55:51 -08:00
2013-12-20 12:55:51 -08:00
2013-12-20 12:55:51 -08:00
2017-08-28 01:44:52 +02:00
2016-09-08 13:50:04 +09:00
2014-05-02 17:21:22 +09:00
2013-12-20 12:55:51 -08:00
2018-01-26 09:06:16 +01:00
2016-04-12 14:18:12 +00:00
2017-08-31 12:19:58 -04:00
2016-07-08 13:45:28 +02:00
2013-12-20 12:55:51 -08:00
2017-12-05 15:57:58 +01:00
2014-10-21 11:04:42 +09:00
2017-07-14 13:25:19 +09:00
2018-01-12 21:34:22 +09:00
2018-01-11 11:37:18 -06:00
2017-08-03 07:50:47 -07:00
2018-03-29 10:26:18 -04:00
2018-02-02 08:21:06 +09:00
2018-04-09 09:02:13 +00:00
2018-01-25 14:17:24 -08:00
2018-04-09 09:02:26 +00:00
2017-11-04 00:45:48 +00:00
2018-04-10 08:27:07 +02:00
2018-02-07 15:04:41 -05:00
2018-03-30 16:38:17 -07:00
2018-04-06 15:24:56 -07:00
2018-04-06 15:24:56 -07:00
2018-04-06 15:24:56 -07:00
2018-01-25 01:57:07 +00:00
2017-12-27 21:40:31 +00:00
2018-01-04 15:59:48 -08:00
2018-01-10 23:41:09 +00:00
2017-08-08 14:24:34 +02:00
2016-07-08 13:47:29 +02:00
2017-04-26 09:28:57 +02:00
2016-10-06 17:20:01 +02:00
2017-09-07 14:50:39 +00:00
2018-02-15 21:40:22 +00:00
2017-01-12 00:25:25 +00:00
2017-07-04 21:20:47 +09:00
2016-07-08 15:26:42 +02:00
2016-07-08 13:47:29 +02:00
2016-07-08 13:47:29 +02:00
2018-03-29 10:26:18 -04:00
2018-02-16 14:04:01 +00:00
2018-02-16 14:04:01 +00:00
2018-03-23 09:31:44 +00:00
2018-02-15 14:13:44 +01:00
2018-04-10 09:33:22 +02:00
2018-04-05 15:30:12 +02:00
2018-02-21 08:10:43 +01:00
2017-01-23 12:44:58 +00:00
2018-03-29 10:26:18 -04:00
2017-08-10 22:43:32 +01:00
2018-01-25 14:22:45 +01:00
2017-06-16 20:57:16 -07:00
2015-06-25 07:26:25 +02:00
2017-09-30 15:47:14 +02:00
2015-04-30 14:37:09 +00:00
2017-09-15 07:50:36 +02:00
2015-09-03 10:50:07 -06:00
2015-09-04 14:55:15 +00:00
2017-11-22 14:23:03 -08:00
2017-09-30 15:47:14 +02:00
2018-03-25 13:55:14 +01:00
2017-09-13 14:57:46 +02:00
2017-10-13 13:54:25 +02:00
2018-03-22 19:34:53 +09:00
2014-03-25 19:44:49 +00:00
2016-11-15 18:20:16 -08:00
2018-04-10 23:32:59 +00:00