06cf5833a3
The editable label was setting focus on the dropdown immediately due to it awaiting the wrong exit condition for _awaitOpen, resulting in a race where focus was only sometimes set on the input. The function was borrowed from gr-overlay, which has styles applied to it directly. In the case of the editable label, we must wait for the style to be set on the dropdown instead. Bug: Issue 8980 Change-Id: I31439a2065159976a9aeda52efd366914cae617f
242 lines
6.3 KiB
HTML
242 lines
6.3 KiB
HTML
<!DOCTYPE html>
|
|
<!--
|
|
@license
|
|
Copyright (C) 2016 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
|
<title>gr-editable-label</title>
|
|
|
|
<script src="../../../bower_components/webcomponentsjs/webcomponents-lite.min.js"></script>
|
|
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
|
<link rel="import" href="../../../test/common-test-setup.html"/>
|
|
<script src="../../../bower_components/iron-test-helpers/mock-interactions.js"></script>
|
|
|
|
<link rel="import" href="gr-editable-label.html">
|
|
|
|
<script>void(0);</script>
|
|
|
|
<test-fixture id="basic">
|
|
<template>
|
|
<gr-editable-label
|
|
value="value text"
|
|
placeholder="label text"></gr-editable-label>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<test-fixture id="no-placeholder">
|
|
<template>
|
|
<gr-editable-label value=""></gr-editable-label>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<test-fixture id="read-only">
|
|
<template>
|
|
<gr-editable-label
|
|
read-only
|
|
value="value text"
|
|
placeholder="label text"></gr-editable-label>
|
|
</template>
|
|
</test-fixture>
|
|
|
|
<script>
|
|
suite('gr-editable-label tests', () => {
|
|
let element;
|
|
let elementNoPlaceholder;
|
|
let input;
|
|
let label;
|
|
let sandbox;
|
|
|
|
setup(() => {
|
|
element = fixture('basic');
|
|
elementNoPlaceholder = fixture('no-placeholder');
|
|
|
|
input = element.$.input.$.input;
|
|
label = element.$$('label');
|
|
sandbox = sinon.sandbox.create();
|
|
});
|
|
|
|
teardown(() => {
|
|
sandbox.restore();
|
|
});
|
|
|
|
test('element render', () => {
|
|
// The dropdown is closed and the label is visible:
|
|
assert.isFalse(element.$.dropdown.opened);
|
|
assert.isTrue(label.classList.contains('editable'));
|
|
assert.equal(label.textContent, 'value text');
|
|
const focusSpy = sandbox.spy(element.$.input.$.input, 'focus');
|
|
const showSpy = sandbox.spy(element, '_showDropdown');
|
|
|
|
MockInteractions.tap(label);
|
|
|
|
return showSpy.lastCall.returnValue.then(() => {
|
|
// The dropdown is open (which covers up the label):
|
|
assert.isTrue(element.$.dropdown.opened);
|
|
assert.isTrue(focusSpy.called);
|
|
assert.equal(input.value, 'value text');
|
|
});
|
|
});
|
|
|
|
test('title with placeholder', done => {
|
|
assert.equal(element.title, 'value text');
|
|
element.value = '';
|
|
|
|
element.async(() => {
|
|
assert.equal(element.title, 'label text');
|
|
done();
|
|
});
|
|
});
|
|
|
|
test('title without placeholder', done => {
|
|
assert.equal(elementNoPlaceholder.title, '');
|
|
element.value = 'value text';
|
|
|
|
element.async(() => {
|
|
assert.equal(element.title, 'value text');
|
|
done();
|
|
});
|
|
});
|
|
|
|
test('edit value', done => {
|
|
const editedStub = sandbox.stub();
|
|
element.addEventListener('changed', editedStub);
|
|
assert.isFalse(element.editing);
|
|
|
|
MockInteractions.tap(label);
|
|
|
|
Polymer.dom.flush();
|
|
|
|
assert.isTrue(element.editing);
|
|
element._inputText = 'new text';
|
|
|
|
assert.isFalse(editedStub.called);
|
|
|
|
element.async(() => {
|
|
assert.isTrue(editedStub.called);
|
|
assert.equal(input.value, 'new text');
|
|
assert.isFalse(element.editing);
|
|
done();
|
|
});
|
|
|
|
// Press enter:
|
|
MockInteractions.keyDownOn(input, 13);
|
|
});
|
|
|
|
test('save button', done => {
|
|
const editedStub = sandbox.stub();
|
|
element.addEventListener('changed', editedStub);
|
|
assert.isFalse(element.editing);
|
|
|
|
MockInteractions.tap(label);
|
|
|
|
Polymer.dom.flush();
|
|
|
|
assert.isTrue(element.editing);
|
|
element._inputText = 'new text';
|
|
|
|
assert.isFalse(editedStub.called);
|
|
|
|
element.async(() => {
|
|
assert.isTrue(editedStub.called);
|
|
assert.equal(input.value, 'new text');
|
|
assert.isFalse(element.editing);
|
|
done();
|
|
});
|
|
|
|
// Press enter:
|
|
MockInteractions.tap(element.$.saveBtn, 13);
|
|
});
|
|
|
|
|
|
test('edit and then escape key', done => {
|
|
const editedStub = sandbox.stub();
|
|
element.addEventListener('changed', editedStub);
|
|
assert.isFalse(element.editing);
|
|
|
|
MockInteractions.tap(label);
|
|
|
|
Polymer.dom.flush();
|
|
|
|
assert.isTrue(element.editing);
|
|
element._inputText = 'new text';
|
|
|
|
assert.isFalse(editedStub.called);
|
|
|
|
element.async(() => {
|
|
assert.isFalse(editedStub.called);
|
|
// Text changes sould be discarded.
|
|
assert.equal(input.value, 'value text');
|
|
assert.isFalse(element.editing);
|
|
done();
|
|
});
|
|
|
|
// Press escape:
|
|
MockInteractions.keyDownOn(input, 27);
|
|
});
|
|
|
|
test('cancel button', done => {
|
|
const editedStub = sandbox.stub();
|
|
element.addEventListener('changed', editedStub);
|
|
assert.isFalse(element.editing);
|
|
|
|
MockInteractions.tap(label);
|
|
|
|
Polymer.dom.flush();
|
|
|
|
assert.isTrue(element.editing);
|
|
element._inputText = 'new text';
|
|
|
|
assert.isFalse(editedStub.called);
|
|
|
|
element.async(() => {
|
|
assert.isFalse(editedStub.called);
|
|
// Text changes sould be discarded.
|
|
assert.equal(input.value, 'value text');
|
|
assert.isFalse(element.editing);
|
|
done();
|
|
});
|
|
|
|
// Press escape:
|
|
MockInteractions.tap(element.$.cancelBtn);
|
|
});
|
|
});
|
|
|
|
suite('gr-editable-label read-only tests', () => {
|
|
let element;
|
|
let label;
|
|
|
|
setup(() => {
|
|
element = fixture('read-only');
|
|
label = element.$$('label');
|
|
});
|
|
|
|
test('disallows edit when read-only', () => {
|
|
// The dropdown is closed.
|
|
assert.isFalse(element.$.dropdown.opened);
|
|
MockInteractions.tap(label);
|
|
|
|
Polymer.dom.flush();
|
|
|
|
// The dropdown is still closed.
|
|
assert.isFalse(element.$.dropdown.opened);
|
|
});
|
|
|
|
test('label is not marked as editable', () => {
|
|
assert.isFalse(label.classList.contains('editable'));
|
|
});
|
|
});
|
|
</script>
|