0a741dd21c
Although plugins can register download schemes with arbitrary names, the getter/setter in AccountGeneralPreferences were allowing only a specific enum type corresponding to the core download schemes. Get rid of that enum type, and store arbitrary strings in the database. To avoid a schema upgrade (which would be an annoying multi-step process for a zero-downtime upgrade), convert to/from the old enum-string values in AccountGeneralPreferences. Everywhere else, use the key from the scheme map, e.g. "anonymous http" instead of "ANON_HTTP". This eliminates the special-case code when sending RPCs from the client, and avoids weird undocumented behavior in the set preferences REST API call. Change-Id: I3e2397d8dfa15d20329cc83e1e3fe069c8e021c4
If you are adding a directory here: - Search all pom.xml files for "CORE PLUGIN LIST". - Add the new plugin to that location. - (optional) Thank the Maven developers for making this easy. - Ensure the plugin's pom.xml <version> is the same as Gerrit's own pom.xml(s). Gerrit will only embed a plugin that has the same version as itself. - Register the plugin as a submodule with git submodule.