69eb1512ef
The _getReviewerSuggestions method of gr-account-entry exits early if the change property has not yet been set. This had the effect of preventing a request for reviewer suggestions as soon as the change view loaded. Such a request would succeed if the user was logged in, but its result would be unused. If the user was not logged in it would fail and show an authentication toast. When the account entry autocomplete query was debounced, this rearranged the timing -- now _getReviewerSuggestions was called after the change property had been set so that it would not exit early and would trigger a toast for unauthenticated users. Disable debouncing in account entries again to preserve the original timing. This solution works for the time being -- until we can omit the unused account entries for unauthenticated users. Bug: Issue 8149 Change-Id: I50baebfdde0079470748834075d519510b519c57
50 lines
1.7 KiB
HTML
50 lines
1.7 KiB
HTML
<!--
|
|
@license
|
|
Copyright (C) 2016 The Android Open Source Project
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
-->
|
|
|
|
<link rel="import" href="../../../behaviors/gr-anonymous-name-behavior/gr-anonymous-name-behavior.html">
|
|
<link rel="import" href="../../../bower_components/polymer/polymer.html">
|
|
<link rel="import" href="../../../styles/shared-styles.html">
|
|
<link rel="import" href="../../shared/gr-autocomplete/gr-autocomplete.html">
|
|
<link rel="import" href="../../shared/gr-rest-api-interface/gr-rest-api-interface.html">
|
|
|
|
<dom-module id="gr-account-entry">
|
|
<template>
|
|
<style include="shared-styles">
|
|
gr-autocomplete {
|
|
display: inline-block;
|
|
flex: 1;
|
|
overflow: hidden;
|
|
}
|
|
</style>
|
|
<gr-autocomplete
|
|
id="input"
|
|
borderless="[[borderless]]"
|
|
placeholder="[[placeholder]]"
|
|
threshold="[[suggestFrom]]"
|
|
query="[[query]]"
|
|
allow-non-suggested-values="[[allowAnyInput]]"
|
|
no-debounce
|
|
on-commit="_handleInputCommit"
|
|
clear-on-commit
|
|
warn-uncommitted
|
|
text="{{_inputText}}">
|
|
</gr-autocomplete>
|
|
<gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
|
|
</template>
|
|
<script src="gr-account-entry.js"></script>
|
|
</dom-module>
|