a9807e4c74
The gr-change-actions element organizes change actions into a single, sorted array property for rendering. Formerly, the order was partially established by keeping the actions in separate arrays and rendering them in serial loops, whereas, with this change, the rendering and order is simplified and less redundant. In particular, the `_computeChangeActionValues` and `_computeRevisionActionValues` methods are merged into a new `_computeAllActions` method. Change-Id: I4ff3d1458fe845e0a5932e4aeb6b91dcbb4c20ee
142 lines
4.9 KiB
HTML
142 lines
4.9 KiB
HTML
<!DOCTYPE html>
|
||
<!--
|
||
Copyright (C) 2016 The Android Open Source Project
|
||
|
||
Licensed under the Apache License, Version 2.0 (the "License");
|
||
you may not use this file except in compliance with the License.
|
||
You may obtain a copy of the License at
|
||
|
||
http://www.apache.org/licenses/LICENSE-2.0
|
||
|
||
Unless required by applicable law or agreed to in writing, software
|
||
distributed under the License is distributed on an "AS IS" BASIS,
|
||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||
See the License for the specific language governing permissions and
|
||
limitations under the License.
|
||
-->
|
||
|
||
<meta name="viewport" content="width=device-width, minimum-scale=1.0, initial-scale=1.0, user-scalable=yes">
|
||
<title>gr-change-actions-js-api</title>
|
||
|
||
<script src="../../../bower_components/webcomponentsjs/webcomponents.min.js"></script>
|
||
<script src="../../../bower_components/web-component-tester/browser.js"></script>
|
||
|
||
<link rel="import" href="../../../bower_components/iron-test-helpers/iron-test-helpers.html">
|
||
<!--
|
||
This must refer to the element this interface is wrapping around. Otherwise
|
||
breaking changes to gr-change-actions won’t be noticed.
|
||
-->
|
||
<link rel="import" href="../../change/gr-change-actions/gr-change-actions.html">
|
||
|
||
<test-fixture id="basic">
|
||
<template>
|
||
<gr-change-actions></gr-change-actions>
|
||
</template>
|
||
</test-fixture>
|
||
|
||
<script>
|
||
suite('gr-js-api-interface tests', function() {
|
||
var element;
|
||
var changeActions;
|
||
|
||
// Because deepEqual doesn’t behave in Safari.
|
||
function assertArraysEqual(actual, expected) {
|
||
assert.equal(actual.length, expected.length);
|
||
for (var i = 0; i < actual.length; i++) {
|
||
assert.equal(actual[i], expected[i]);
|
||
}
|
||
}
|
||
|
||
setup(function() {
|
||
element = fixture('basic');
|
||
element.change = {};
|
||
var plugin;
|
||
Gerrit.install(function(p) { plugin = p; }, '0.1',
|
||
'http://test.com/plugins/testplugin/static/test.js');
|
||
changeActions = plugin.changeActions();
|
||
});
|
||
|
||
teardown(function() {
|
||
changeActions = null;
|
||
});
|
||
|
||
test('property existence', function() {
|
||
[
|
||
'ActionType',
|
||
'ChangeActions',
|
||
'RevisionActions',
|
||
].forEach(function(p) {
|
||
assertArraysEqual(changeActions[p], element[p]);
|
||
});
|
||
});
|
||
|
||
test('add/remove primary action keys', function() {
|
||
element.primaryActionKeys = [];
|
||
changeActions.addPrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo']);
|
||
changeActions.addPrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo']);
|
||
changeActions.addPrimaryActionKey('bar');
|
||
assertArraysEqual(element.primaryActionKeys, ['foo', 'bar']);
|
||
changeActions.removePrimaryActionKey('foo');
|
||
assertArraysEqual(element.primaryActionKeys, ['bar']);
|
||
changeActions.removePrimaryActionKey('baz');
|
||
assertArraysEqual(element.primaryActionKeys, ['bar']);
|
||
changeActions.removePrimaryActionKey('bar');
|
||
assertArraysEqual(element.primaryActionKeys, []);
|
||
});
|
||
|
||
test('action buttons', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
var handler = sinon.spy();
|
||
changeActions.addTapListener(key, handler);
|
||
flush(function() {
|
||
MockInteractions.tap(element.$$('[data-action-key="' + key + '"]'));
|
||
assert(handler.calledOnce);
|
||
changeActions.removeTapListener(key, handler);
|
||
MockInteractions.tap(element.$$('[data-action-key="' + key + '"]'));
|
||
assert(handler.calledOnce);
|
||
changeActions.remove(key);
|
||
flush(function() {
|
||
assert.isNull(element.$$('[data-action-key="' + key + '"]'));
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('action button properties', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isOk(button);
|
||
assert.equal(button.getAttribute('data-label'), 'Bork!');
|
||
assert.isFalse(button.disabled);
|
||
changeActions.setLabel(key, 'Yo');
|
||
changeActions.setEnabled(key, false);
|
||
flush(function() {
|
||
assert.equal(button.getAttribute('data-label'), 'Yo');
|
||
assert.isTrue(button.disabled);
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
|
||
test('hide action buttons', function(done) {
|
||
var key = changeActions.add(changeActions.ActionType.REVISION, 'Bork!');
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isOk(button);
|
||
assert.isFalse(button.hasAttribute('hidden'));
|
||
changeActions.setActionHidden(changeActions.ActionType.REVISION, key,
|
||
true);
|
||
flush(function() {
|
||
var button = element.$$('[data-action-key="' + key + '"]');
|
||
assert.isOk(button);
|
||
assert.isTrue(button.hasAttribute('hidden'));
|
||
done();
|
||
});
|
||
});
|
||
});
|
||
});
|
||
</script>
|