
When a change in Gerrit is submitted, it's possible that the submission includes other changes: 1. Open parent changes (unless the submit type is cherry-pick). 2. Open changes with the same topic (if change.submitWholeTopic in gerrit.config is set to true). Those changes with the same topic could be in different repositories or different branches. If the submission of a change introduced an issue, users often revert the change to resolve the issue, but this may cause breakages if the change had been submitted together with other changes. Usually changes that are submitted together depend on each other, so that reverting only one of the changes breaks the other changes. Hence if a submission contains multiple changes, one needs to revert all of the changes which have been submitted together. At the moment this can only be done by calling the Revert Change REST endpoint for each of the changes one by one. The new Revert by Submission REST endpoint allows to revert all changes of a submission. Since we don't have REST resources that represent submissions, the REST endpoint is offered on change level, meaning that this change and all changes that have been submitted together with this change should be reverted. It's a new REST endpoint, rather than a new flag for the existing Revert Change REST endpoint, because it needs to return a set of revert changes which can't be done from the Revert Change REST endpoint without breaking backwards compatibility (the result of the existing Revert Change REST endpoint is a single change). The only functionality added here is the ability to revert all changes with a single button. However, the changes will not be rebased on top of each other so the users may need to rebase them manually to make them submittable. The Revert by Submission REST endpoint has the following steps: 1. Check that the change for which the Revert by Submission endpoint is invoked is merged. A change that is not merged does not have a submission ID and thus we can't revert the submission of such change. 2. Find all changes that were submitted together: For this we take the submission ID of the change on which the REST endpoint was invoked and query for all changes with this submission ID. The ID of a submission is already contained in the change index and internally we can easily query changes by it (although querying changes by submission ID is not exposed to users). 3. Next we make all necessary validations such as permission validations, and ensuring the existence of all the changes. 4. Revert all changes one by one using the Revert REST endpoint. Each newly created change will have a topic that was given by the user, or a default "revert-<submission_id>-<random_string_of_size_10>". What happens when users revert the same submission twice? - Duplicate revert changes are created but they will have different unique topics. What if a submission contains a single change? - The result is similar to the result of the Revert Change REST endpoint. The only difference is that the topic of the revert change is set to 'revert-<submission-id>-<random_string_of_size_10>'. Next steps: * Optionally, when the revert submission is finished, the user should see a list of the revert changes. * When reverting a submission through the UI, the user should insert the reason for reverting this submission. * [Optional] Revert Submission action should show a preview of the changes that are going to be reverted. * Make the reverts stack on top of each other when in the same branch and in the same repository. It should always succeed since it will not rebase on top of the destination branch. * Add an option to rebase automatically on top of the destination branch. * [Optional] Add an option for interactive revert that allows the user to resolve conflicts when occur (similar to interactive rebase). * Create all reverts in a single batch. This way we also avoid multiple permissions checks. * [Google only] Consider using sharded computation, similar to submitting together multiple changes across multiple repositories. Change-Id: I7188c0d520afa669fd78309c39d44656c38259dd
751 lines
26 KiB
Java
751 lines
26 KiB
Java
// Copyright (C) 2013 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server.api.changes;
|
|
|
|
import static com.google.gerrit.server.api.ApiUtil.asRestApiException;
|
|
|
|
import com.google.common.collect.ImmutableListMultimap;
|
|
import com.google.common.collect.ListMultimap;
|
|
import com.google.gerrit.common.Nullable;
|
|
import com.google.gerrit.exceptions.StorageException;
|
|
import com.google.gerrit.extensions.api.changes.AbandonInput;
|
|
import com.google.gerrit.extensions.api.changes.AddReviewerInput;
|
|
import com.google.gerrit.extensions.api.changes.AddReviewerResult;
|
|
import com.google.gerrit.extensions.api.changes.AssigneeInput;
|
|
import com.google.gerrit.extensions.api.changes.ChangeApi;
|
|
import com.google.gerrit.extensions.api.changes.ChangeEditApi;
|
|
import com.google.gerrit.extensions.api.changes.ChangeMessageApi;
|
|
import com.google.gerrit.extensions.api.changes.Changes;
|
|
import com.google.gerrit.extensions.api.changes.FixInput;
|
|
import com.google.gerrit.extensions.api.changes.HashtagsInput;
|
|
import com.google.gerrit.extensions.api.changes.IncludedInInfo;
|
|
import com.google.gerrit.extensions.api.changes.MoveInput;
|
|
import com.google.gerrit.extensions.api.changes.RebaseInput;
|
|
import com.google.gerrit.extensions.api.changes.RestoreInput;
|
|
import com.google.gerrit.extensions.api.changes.RevertInput;
|
|
import com.google.gerrit.extensions.api.changes.ReviewerApi;
|
|
import com.google.gerrit.extensions.api.changes.ReviewerInfo;
|
|
import com.google.gerrit.extensions.api.changes.RevisionApi;
|
|
import com.google.gerrit.extensions.api.changes.SubmittedTogetherInfo;
|
|
import com.google.gerrit.extensions.api.changes.SubmittedTogetherOption;
|
|
import com.google.gerrit.extensions.api.changes.TopicInput;
|
|
import com.google.gerrit.extensions.client.ListChangesOption;
|
|
import com.google.gerrit.extensions.common.AccountInfo;
|
|
import com.google.gerrit.extensions.common.ChangeInfo;
|
|
import com.google.gerrit.extensions.common.ChangeMessageInfo;
|
|
import com.google.gerrit.extensions.common.CommentInfo;
|
|
import com.google.gerrit.extensions.common.CommitMessageInput;
|
|
import com.google.gerrit.extensions.common.Input;
|
|
import com.google.gerrit.extensions.common.MergePatchSetInput;
|
|
import com.google.gerrit.extensions.common.PureRevertInfo;
|
|
import com.google.gerrit.extensions.common.RevertSubmissionInfo;
|
|
import com.google.gerrit.extensions.common.RobotCommentInfo;
|
|
import com.google.gerrit.extensions.common.SuggestedReviewerInfo;
|
|
import com.google.gerrit.extensions.registration.DynamicMap;
|
|
import com.google.gerrit.extensions.restapi.BadRequestException;
|
|
import com.google.gerrit.extensions.restapi.IdString;
|
|
import com.google.gerrit.extensions.restapi.Response;
|
|
import com.google.gerrit.extensions.restapi.RestApiException;
|
|
import com.google.gerrit.server.DynamicOptions;
|
|
import com.google.gerrit.server.StarredChangesUtil;
|
|
import com.google.gerrit.server.StarredChangesUtil.IllegalLabelException;
|
|
import com.google.gerrit.server.change.ChangeMessageResource;
|
|
import com.google.gerrit.server.change.ChangeResource;
|
|
import com.google.gerrit.server.change.SetPrivateOp;
|
|
import com.google.gerrit.server.change.WorkInProgressOp;
|
|
import com.google.gerrit.server.restapi.change.Abandon;
|
|
import com.google.gerrit.server.restapi.change.ChangeIncludedIn;
|
|
import com.google.gerrit.server.restapi.change.ChangeMessages;
|
|
import com.google.gerrit.server.restapi.change.Check;
|
|
import com.google.gerrit.server.restapi.change.CreateMergePatchSet;
|
|
import com.google.gerrit.server.restapi.change.DeleteAssignee;
|
|
import com.google.gerrit.server.restapi.change.DeleteChange;
|
|
import com.google.gerrit.server.restapi.change.DeletePrivate;
|
|
import com.google.gerrit.server.restapi.change.GetAssignee;
|
|
import com.google.gerrit.server.restapi.change.GetChange;
|
|
import com.google.gerrit.server.restapi.change.GetHashtags;
|
|
import com.google.gerrit.server.restapi.change.GetPastAssignees;
|
|
import com.google.gerrit.server.restapi.change.GetPureRevert;
|
|
import com.google.gerrit.server.restapi.change.GetTopic;
|
|
import com.google.gerrit.server.restapi.change.Ignore;
|
|
import com.google.gerrit.server.restapi.change.Index;
|
|
import com.google.gerrit.server.restapi.change.ListChangeComments;
|
|
import com.google.gerrit.server.restapi.change.ListChangeDrafts;
|
|
import com.google.gerrit.server.restapi.change.ListChangeRobotComments;
|
|
import com.google.gerrit.server.restapi.change.ListReviewers;
|
|
import com.google.gerrit.server.restapi.change.MarkAsReviewed;
|
|
import com.google.gerrit.server.restapi.change.MarkAsUnreviewed;
|
|
import com.google.gerrit.server.restapi.change.Move;
|
|
import com.google.gerrit.server.restapi.change.PostHashtags;
|
|
import com.google.gerrit.server.restapi.change.PostPrivate;
|
|
import com.google.gerrit.server.restapi.change.PostReviewers;
|
|
import com.google.gerrit.server.restapi.change.PutAssignee;
|
|
import com.google.gerrit.server.restapi.change.PutMessage;
|
|
import com.google.gerrit.server.restapi.change.PutTopic;
|
|
import com.google.gerrit.server.restapi.change.Rebase;
|
|
import com.google.gerrit.server.restapi.change.Restore;
|
|
import com.google.gerrit.server.restapi.change.Revert;
|
|
import com.google.gerrit.server.restapi.change.RevertSubmission;
|
|
import com.google.gerrit.server.restapi.change.Reviewers;
|
|
import com.google.gerrit.server.restapi.change.Revisions;
|
|
import com.google.gerrit.server.restapi.change.SetReadyForReview;
|
|
import com.google.gerrit.server.restapi.change.SetWorkInProgress;
|
|
import com.google.gerrit.server.restapi.change.SubmittedTogether;
|
|
import com.google.gerrit.server.restapi.change.SuggestChangeReviewers;
|
|
import com.google.gerrit.server.restapi.change.Unignore;
|
|
import com.google.gerrit.util.cli.CmdLineParser;
|
|
import com.google.inject.Inject;
|
|
import com.google.inject.Injector;
|
|
import com.google.inject.Provider;
|
|
import com.google.inject.Singleton;
|
|
import com.google.inject.assistedinject.Assisted;
|
|
import java.util.EnumSet;
|
|
import java.util.List;
|
|
import java.util.Map;
|
|
import java.util.Set;
|
|
import org.kohsuke.args4j.CmdLineException;
|
|
|
|
class ChangeApiImpl implements ChangeApi {
|
|
interface Factory {
|
|
ChangeApiImpl create(ChangeResource change);
|
|
}
|
|
|
|
private final Changes changeApi;
|
|
private final Reviewers reviewers;
|
|
private final Revisions revisions;
|
|
private final ReviewerApiImpl.Factory reviewerApi;
|
|
private final RevisionApiImpl.Factory revisionApi;
|
|
private final ChangeMessageApiImpl.Factory changeMessageApi;
|
|
private final ChangeMessages changeMessages;
|
|
private final SuggestChangeReviewers suggestReviewers;
|
|
private final ListReviewers listReviewers;
|
|
private final ChangeResource change;
|
|
private final Abandon abandon;
|
|
private final Revert revert;
|
|
private final RevertSubmission revertSubmission;
|
|
private final Restore restore;
|
|
private final CreateMergePatchSet updateByMerge;
|
|
private final Provider<SubmittedTogether> submittedTogether;
|
|
private final Rebase.CurrentRevision rebase;
|
|
private final DeleteChange deleteChange;
|
|
private final GetTopic getTopic;
|
|
private final PutTopic putTopic;
|
|
private final ChangeIncludedIn includedIn;
|
|
private final PostReviewers postReviewers;
|
|
private final Provider<GetChange> getChangeProvider;
|
|
private final PostHashtags postHashtags;
|
|
private final GetHashtags getHashtags;
|
|
private final PutAssignee putAssignee;
|
|
private final GetAssignee getAssignee;
|
|
private final GetPastAssignees getPastAssignees;
|
|
private final DeleteAssignee deleteAssignee;
|
|
private final ListChangeComments listComments;
|
|
private final ListChangeRobotComments listChangeRobotComments;
|
|
private final ListChangeDrafts listDrafts;
|
|
private final ChangeEditApiImpl.Factory changeEditApi;
|
|
private final Check check;
|
|
private final Index index;
|
|
private final Move move;
|
|
private final PostPrivate postPrivate;
|
|
private final DeletePrivate deletePrivate;
|
|
private final Ignore ignore;
|
|
private final Unignore unignore;
|
|
private final MarkAsReviewed markAsReviewed;
|
|
private final MarkAsUnreviewed markAsUnreviewed;
|
|
private final SetWorkInProgress setWip;
|
|
private final SetReadyForReview setReady;
|
|
private final PutMessage putMessage;
|
|
private final Provider<GetPureRevert> getPureRevertProvider;
|
|
private final StarredChangesUtil stars;
|
|
private final DynamicOptionParser dynamicOptionParser;
|
|
|
|
@Inject
|
|
ChangeApiImpl(
|
|
Changes changeApi,
|
|
Reviewers reviewers,
|
|
Revisions revisions,
|
|
ReviewerApiImpl.Factory reviewerApi,
|
|
RevisionApiImpl.Factory revisionApi,
|
|
ChangeMessageApiImpl.Factory changeMessageApi,
|
|
ChangeMessages changeMessages,
|
|
SuggestChangeReviewers suggestReviewers,
|
|
ListReviewers listReviewers,
|
|
Abandon abandon,
|
|
Revert revert,
|
|
RevertSubmission revertSubmission,
|
|
Restore restore,
|
|
CreateMergePatchSet updateByMerge,
|
|
Provider<SubmittedTogether> submittedTogether,
|
|
Rebase.CurrentRevision rebase,
|
|
DeleteChange deleteChange,
|
|
GetTopic getTopic,
|
|
PutTopic putTopic,
|
|
ChangeIncludedIn includedIn,
|
|
PostReviewers postReviewers,
|
|
Provider<GetChange> getChangeProvider,
|
|
PostHashtags postHashtags,
|
|
GetHashtags getHashtags,
|
|
PutAssignee putAssignee,
|
|
GetAssignee getAssignee,
|
|
GetPastAssignees getPastAssignees,
|
|
DeleteAssignee deleteAssignee,
|
|
ListChangeComments listComments,
|
|
ListChangeRobotComments listChangeRobotComments,
|
|
ListChangeDrafts listDrafts,
|
|
ChangeEditApiImpl.Factory changeEditApi,
|
|
Check check,
|
|
Index index,
|
|
Move move,
|
|
PostPrivate postPrivate,
|
|
DeletePrivate deletePrivate,
|
|
Ignore ignore,
|
|
Unignore unignore,
|
|
MarkAsReviewed markAsReviewed,
|
|
MarkAsUnreviewed markAsUnreviewed,
|
|
SetWorkInProgress setWip,
|
|
SetReadyForReview setReady,
|
|
PutMessage putMessage,
|
|
Provider<GetPureRevert> getPureRevertProvider,
|
|
StarredChangesUtil stars,
|
|
DynamicOptionParser dynamicOptionParser,
|
|
@Assisted ChangeResource change) {
|
|
this.changeApi = changeApi;
|
|
this.revert = revert;
|
|
this.revertSubmission = revertSubmission;
|
|
this.reviewers = reviewers;
|
|
this.revisions = revisions;
|
|
this.reviewerApi = reviewerApi;
|
|
this.revisionApi = revisionApi;
|
|
this.changeMessageApi = changeMessageApi;
|
|
this.changeMessages = changeMessages;
|
|
this.suggestReviewers = suggestReviewers;
|
|
this.listReviewers = listReviewers;
|
|
this.abandon = abandon;
|
|
this.restore = restore;
|
|
this.updateByMerge = updateByMerge;
|
|
this.submittedTogether = submittedTogether;
|
|
this.rebase = rebase;
|
|
this.deleteChange = deleteChange;
|
|
this.getTopic = getTopic;
|
|
this.putTopic = putTopic;
|
|
this.includedIn = includedIn;
|
|
this.postReviewers = postReviewers;
|
|
this.getChangeProvider = getChangeProvider;
|
|
this.postHashtags = postHashtags;
|
|
this.getHashtags = getHashtags;
|
|
this.putAssignee = putAssignee;
|
|
this.getAssignee = getAssignee;
|
|
this.getPastAssignees = getPastAssignees;
|
|
this.deleteAssignee = deleteAssignee;
|
|
this.listComments = listComments;
|
|
this.listChangeRobotComments = listChangeRobotComments;
|
|
this.listDrafts = listDrafts;
|
|
this.changeEditApi = changeEditApi;
|
|
this.check = check;
|
|
this.index = index;
|
|
this.move = move;
|
|
this.postPrivate = postPrivate;
|
|
this.deletePrivate = deletePrivate;
|
|
this.ignore = ignore;
|
|
this.unignore = unignore;
|
|
this.markAsReviewed = markAsReviewed;
|
|
this.markAsUnreviewed = markAsUnreviewed;
|
|
this.setWip = setWip;
|
|
this.setReady = setReady;
|
|
this.putMessage = putMessage;
|
|
this.getPureRevertProvider = getPureRevertProvider;
|
|
this.stars = stars;
|
|
this.dynamicOptionParser = dynamicOptionParser;
|
|
this.change = change;
|
|
}
|
|
|
|
@Override
|
|
public String id() {
|
|
return Integer.toString(change.getId().get());
|
|
}
|
|
|
|
@Override
|
|
public RevisionApi revision(String id) throws RestApiException {
|
|
try {
|
|
return revisionApi.create(revisions.parse(change, IdString.fromDecoded(id)));
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot parse revision", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ReviewerApi reviewer(String id) throws RestApiException {
|
|
try {
|
|
return reviewerApi.create(reviewers.parse(change, IdString.fromDecoded(id)));
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot parse reviewer", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void abandon(AbandonInput in) throws RestApiException {
|
|
try {
|
|
abandon.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot abandon change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void restore(RestoreInput in) throws RestApiException {
|
|
try {
|
|
restore.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot restore change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void move(MoveInput in) throws RestApiException {
|
|
try {
|
|
move.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot move change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void setPrivate(boolean value, @Nullable String message) throws RestApiException {
|
|
try {
|
|
SetPrivateOp.Input input = new SetPrivateOp.Input(message);
|
|
if (value) {
|
|
postPrivate.apply(change, input);
|
|
} else {
|
|
deletePrivate.apply(change, input);
|
|
}
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot change private status", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void setWorkInProgress(@Nullable String message) throws RestApiException {
|
|
try {
|
|
setWip.apply(change, new WorkInProgressOp.Input(message));
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot set work in progress state", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void setReadyForReview(@Nullable String message) throws RestApiException {
|
|
try {
|
|
setReady.apply(change, new WorkInProgressOp.Input(message));
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot set ready for review state", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeApi revert(RevertInput in) throws RestApiException {
|
|
try {
|
|
return changeApi.id(revert.apply(change, in).value()._number);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot revert change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public RevertSubmissionInfo revertSubmission(RevertInput in) throws RestApiException {
|
|
try {
|
|
return revertSubmission.apply(change, in).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot revert a change submission", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeInfo createMergePatchSet(MergePatchSetInput in) throws RestApiException {
|
|
try {
|
|
return updateByMerge.apply(change, in).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot update change by merge", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public SubmittedTogetherInfo submittedTogether(
|
|
EnumSet<ListChangesOption> listOptions, EnumSet<SubmittedTogetherOption> submitOptions)
|
|
throws RestApiException {
|
|
try {
|
|
return submittedTogether
|
|
.get()
|
|
.addListChangesOption(listOptions)
|
|
.addSubmittedTogetherOption(submitOptions)
|
|
.applyInfo(change);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot query submittedTogether", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void rebase(RebaseInput in) throws RestApiException {
|
|
try {
|
|
rebase.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot rebase change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void delete() throws RestApiException {
|
|
try {
|
|
deleteChange.apply(change, null);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot delete change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public String topic() throws RestApiException {
|
|
try {
|
|
return getTopic.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get topic", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void topic(String topic) throws RestApiException {
|
|
TopicInput in = new TopicInput();
|
|
in.topic = topic;
|
|
try {
|
|
putTopic.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot set topic", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public IncludedInInfo includedIn() throws RestApiException {
|
|
try {
|
|
return includedIn.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Could not extract IncludedIn data", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public AddReviewerResult addReviewer(AddReviewerInput in) throws RestApiException {
|
|
try {
|
|
return postReviewers.apply(change, in).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot add change reviewer", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public SuggestedReviewersRequest suggestReviewers() throws RestApiException {
|
|
return new SuggestedReviewersRequest() {
|
|
@Override
|
|
public List<SuggestedReviewerInfo> get() throws RestApiException {
|
|
return ChangeApiImpl.this.suggestReviewers(this);
|
|
}
|
|
};
|
|
}
|
|
|
|
private List<SuggestedReviewerInfo> suggestReviewers(SuggestedReviewersRequest r)
|
|
throws RestApiException {
|
|
try {
|
|
suggestReviewers.setQuery(r.getQuery());
|
|
suggestReviewers.setLimit(r.getLimit());
|
|
suggestReviewers.setExcludeGroups(r.getExcludeGroups());
|
|
suggestReviewers.setReviewerState(r.getReviewerState());
|
|
return suggestReviewers.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot retrieve suggested reviewers", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public List<ReviewerInfo> reviewers() throws RestApiException {
|
|
try {
|
|
return listReviewers.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot retrieve reviewers", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeInfo get(
|
|
EnumSet<ListChangesOption> options, ImmutableListMultimap<String, String> pluginOptions)
|
|
throws RestApiException {
|
|
try {
|
|
GetChange getChange = getChangeProvider.get();
|
|
options.forEach(getChange::addOption);
|
|
dynamicOptionParser.parseDynamicOptions(getChange, pluginOptions);
|
|
return getChange.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot retrieve change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeEditApi edit() throws RestApiException {
|
|
return changeEditApi.create(change);
|
|
}
|
|
|
|
@Override
|
|
public void setMessage(CommitMessageInput in) throws RestApiException {
|
|
try {
|
|
putMessage.apply(change, in);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot edit commit message", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void setHashtags(HashtagsInput input) throws RestApiException {
|
|
try {
|
|
postHashtags.apply(change, input);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot post hashtags", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public Set<String> getHashtags() throws RestApiException {
|
|
try {
|
|
return getHashtags.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get hashtags", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public AccountInfo setAssignee(AssigneeInput input) throws RestApiException {
|
|
try {
|
|
return putAssignee.apply(change, input).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot set assignee", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public AccountInfo getAssignee() throws RestApiException {
|
|
try {
|
|
Response<AccountInfo> r = getAssignee.apply(change);
|
|
return r.isNone() ? null : r.value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get assignee", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public List<AccountInfo> getPastAssignees() throws RestApiException {
|
|
try {
|
|
return getPastAssignees.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get past assignees", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public AccountInfo deleteAssignee() throws RestApiException {
|
|
try {
|
|
Response<AccountInfo> r = deleteAssignee.apply(change, null);
|
|
return r.isNone() ? null : r.value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot delete assignee", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public Map<String, List<CommentInfo>> comments() throws RestApiException {
|
|
try {
|
|
return listComments.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get comments", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public List<CommentInfo> commentsAsList() throws RestApiException {
|
|
try {
|
|
return listComments.getComments(change);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get comments", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public Map<String, List<RobotCommentInfo>> robotComments() throws RestApiException {
|
|
try {
|
|
return listChangeRobotComments.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get robot comments", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public Map<String, List<CommentInfo>> drafts() throws RestApiException {
|
|
try {
|
|
return listDrafts.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get drafts", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public List<CommentInfo> draftsAsList() throws RestApiException {
|
|
try {
|
|
return listDrafts.getComments(change);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot get drafts", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeInfo check() throws RestApiException {
|
|
try {
|
|
return check.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot check change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeInfo check(FixInput fix) throws RestApiException {
|
|
try {
|
|
// TODO(dborowitz): Convert to RetryingRestModifyView. Needs to plumb BatchUpdate.Factory into
|
|
// ConsistencyChecker.
|
|
return check.apply(change, fix).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot check change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void index() throws RestApiException {
|
|
try {
|
|
index.apply(change, new Input());
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot index change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void ignore(boolean ignore) throws RestApiException {
|
|
// TODO(dborowitz): Convert to RetryingRestModifyView. Needs to plumb BatchUpdate.Factory into
|
|
// StarredChangesUtil.
|
|
try {
|
|
if (ignore) {
|
|
this.ignore.apply(change, new Input());
|
|
} else {
|
|
unignore.apply(change, new Input());
|
|
}
|
|
} catch (StorageException | IllegalLabelException e) {
|
|
throw asRestApiException("Cannot ignore change", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public boolean ignored() throws RestApiException {
|
|
try {
|
|
return stars.isIgnored(change);
|
|
} catch (StorageException e) {
|
|
throw asRestApiException("Cannot check if ignored", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public void markAsReviewed(boolean reviewed) throws RestApiException {
|
|
// TODO(dborowitz): Convert to RetryingRestModifyView. Needs to plumb BatchUpdate.Factory into
|
|
// StarredChangesUtil.
|
|
try {
|
|
if (reviewed) {
|
|
markAsReviewed.apply(change, new Input());
|
|
} else {
|
|
markAsUnreviewed.apply(change, new Input());
|
|
}
|
|
} catch (StorageException | IllegalLabelException e) {
|
|
throw asRestApiException(
|
|
"Cannot mark change as " + (reviewed ? "reviewed" : "unreviewed"), e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public PureRevertInfo pureRevert() throws RestApiException {
|
|
return pureRevert(null);
|
|
}
|
|
|
|
@Override
|
|
public PureRevertInfo pureRevert(@Nullable String claimedOriginal) throws RestApiException {
|
|
try {
|
|
GetPureRevert getPureRevert = getPureRevertProvider.get();
|
|
getPureRevert.setClaimedOriginal(claimedOriginal);
|
|
return getPureRevert.apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot compute pure revert", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public List<ChangeMessageInfo> messages() throws RestApiException {
|
|
try {
|
|
return changeMessages.list().apply(change).value();
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot list change messages", e);
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public ChangeMessageApi message(String id) throws RestApiException {
|
|
try {
|
|
ChangeMessageResource resource = changeMessages.parse(change, IdString.fromDecoded(id));
|
|
return changeMessageApi.create(resource);
|
|
} catch (Exception e) {
|
|
throw asRestApiException("Cannot parse change message " + id, e);
|
|
}
|
|
}
|
|
|
|
@Singleton
|
|
static class DynamicOptionParser {
|
|
private final CmdLineParser.Factory cmdLineParserFactory;
|
|
private final Injector injector;
|
|
private final DynamicMap<DynamicOptions.DynamicBean> dynamicBeans;
|
|
|
|
@Inject
|
|
DynamicOptionParser(
|
|
CmdLineParser.Factory cmdLineParserFactory,
|
|
Injector injector,
|
|
DynamicMap<DynamicOptions.DynamicBean> dynamicBeans) {
|
|
this.cmdLineParserFactory = cmdLineParserFactory;
|
|
this.injector = injector;
|
|
this.dynamicBeans = dynamicBeans;
|
|
}
|
|
|
|
void parseDynamicOptions(Object bean, ListMultimap<String, String> pluginOptions)
|
|
throws BadRequestException {
|
|
CmdLineParser clp = cmdLineParserFactory.create(bean);
|
|
DynamicOptions dynamicOptions = new DynamicOptions(bean, injector, dynamicBeans);
|
|
dynamicOptions.parseDynamicBeans(clp);
|
|
dynamicOptions.setDynamicBeans();
|
|
dynamicOptions.onBeanParseStart();
|
|
try {
|
|
clp.parseOptionMap(pluginOptions);
|
|
} catch (CmdLineException | NumberFormatException e) {
|
|
throw new BadRequestException(e.getMessage(), e);
|
|
}
|
|
dynamicOptions.onBeanParseEnd();
|
|
}
|
|
}
|
|
}
|