b82043a3a5
This brings the comment list (both in the messages at the bottom and in the reply modal dialog) into line with the file list, emails, and other places the file names are displayed. Change-Id: Id0ef2e3bafb63070d2284e4b70613ac92300d14d
85 lines
2.4 KiB
JavaScript
85 lines
2.4 KiB
JavaScript
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function() {
|
|
'use strict';
|
|
|
|
var COMMIT_MESSAGE_PATH = '/COMMIT_MSG';
|
|
var MERGE_LIST_PATH = '/MERGE_LIST';
|
|
|
|
Polymer({
|
|
is: 'gr-comment-list',
|
|
|
|
behaviors: [
|
|
Gerrit.BaseUrlBehavior,
|
|
Gerrit.PathListBehavior,
|
|
],
|
|
|
|
properties: {
|
|
changeNum: Number,
|
|
comments: Object,
|
|
patchNum: Number,
|
|
projectConfig: Object,
|
|
},
|
|
|
|
_computeFilesFromComments: function(comments) {
|
|
var arr = Object.keys(comments || {});
|
|
return arr.sort(this.specialFilePathCompare);
|
|
},
|
|
|
|
_computeFileDiffURL: function(file, changeNum, patchNum) {
|
|
return this.getBaseUrl() + '/c/' + changeNum +
|
|
'/' + patchNum + '/' + file;
|
|
},
|
|
|
|
_computeFileDisplayName: function(path) {
|
|
if (path === COMMIT_MESSAGE_PATH) {
|
|
return 'Commit message';
|
|
} else if (path === MERGE_LIST_PATH) {
|
|
return 'Merge list';
|
|
}
|
|
return path;
|
|
},
|
|
|
|
_isOnParent: function(comment) {
|
|
return comment.side === 'PARENT';
|
|
},
|
|
|
|
_computeDiffLineURL: function(file, changeNum, patchNum, comment) {
|
|
var diffURL = this._computeFileDiffURL(file, changeNum, patchNum);
|
|
if (comment.line) {
|
|
diffURL += '#';
|
|
if (this._isOnParent(comment)) { diffURL += 'b'; }
|
|
diffURL += comment.line;
|
|
}
|
|
return diffURL;
|
|
},
|
|
|
|
_computeCommentsForFile: function(comments, file) {
|
|
// Changes are not picked up by the dom-repeat due to the array instance
|
|
// identity not changing even when it has elements added/removed from it.
|
|
return (comments[file] || []).slice();
|
|
},
|
|
|
|
_computePatchDisplayName: function(comment) {
|
|
if (this._isOnParent(comment)) {
|
|
return 'Base, ';
|
|
}
|
|
if (comment.patch_set != this.patchNum) {
|
|
return 'PS' + comment.patch_set + ', ';
|
|
}
|
|
return '';
|
|
},
|
|
});
|
|
})();
|