opendev/gerrit
Code Issues Proposed changes
b942d0b0a2
gerrit/Documentation
History
Sven Selberg e7f3f0a206 Make handling of web links consistent 
The WebLinks class now provides all web links as FluentIterables which
avoids unnecessary copying in the caller. Web links that do not have a
name or URL are now always filtered out in the WebLinks class and
callers don't need to do this anymore. In addition, if there are no web
links, the web_links field is not set in the JSON that is sent to
clients.

Implementations of *WebLink can now also return null to indicate that
no web link should be shown for the resource described by the provided
parameters.

Some of these improvements were already done for file web links by
b62414c0c and 2ae832e7e.

Change-Id: I28b98c25ab0f8c4411a6be845181560a636f5e8d
2014-10-26 18:32:38 +00:00
..
images Add diff pref whether the diff table header should be auto hidden 2014-09-17 16:03:59 +02:00
man Add SSH command to set group members 2013-06-14 20:30:32 +02:00
.gitignore Documentation/Makefile: Remove SVN publish support 2014-05-19 13:42:34 -07:00
access-control.txt Remove the generateHttpPassword capability 2014-09-29 15:21:06 -07:00
asciidoc.conf Add asciidoc build back in the Documentation folder 2014-05-14 11:05:42 +09:00
asciidoc.defs Add buck rule to generate docs for static hosting. 2014-09-05 14:19:15 -07:00
BUCK Add buck rule to generate docs for static hosting. 2014-09-05 14:19:15 -07:00
cmd-apropos.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ban-commit.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-cherry-pick.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-account.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-branch.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-group.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-create-project.txt Option to create a new change for every commit not in target 2014-09-11 15:10:08 +02:00
cmd-flush-caches.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-gc.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-gsql.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-hook-commit-msg.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-index.txt Add SSH to configure logging level at runtime 2014-09-26 09:13:35 -04:00
cmd-kill.txt Revert "== GERRIT" in documentation. 2014-03-25 19:44:49 +00:00
cmd-logging-ls-level.txt Add SSH to configure logging level at runtime 2014-09-26 09:13:35 -04:00
cmd-logging-set-level.txt Add SSH to configure logging level at runtime 2014-09-26 09:13:35 -04:00
cmd-ls-groups.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ls-members.txt Documentation: Format fix headlines 2014-03-24 18:32:42 -07:00
cmd-ls-projects.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-ls-user-refs.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-enable.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-install.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-ls.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-reload.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-plugin-remove.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-query.txt SSH query command: Remove resume_sortkey query operator 2014-08-11 09:41:32 -07:00
cmd-receive-pack.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-rename-group.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-review.txt Add --rebase option to review command 2014-09-09 13:08:04 -04:00
cmd-set-account.txt Close security hole allowing normal user to become admin 2014-10-03 09:53:34 +00:00
cmd-set-members.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-set-project-parent.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-set-project.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
cmd-set-reviewers.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
cmd-show-caches.txt Merge "Require 'Administrate Server' capability to see server summary" 2014-07-02 18:57:01 +00:00
cmd-show-connections.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-show-queue.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-stream-events.txt Add stream event and hook for hashtag changes 2014-09-12 16:45:54 +02:00
cmd-suexec.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-test-submit-rule.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-test-submit-type.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
cmd-version.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-auto-site-initialization.txt Control which plugins will be auto installed on auto init 2014-02-24 11:11:04 +01:00
config-cla.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-contact.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-gerrit.txt Allow configuration of SSH rekey values 2014-10-14 09:48:42 +09:00
config-gitweb.txt Documentation: Case consistencies for SEE ALSO 2014-03-24 19:02:08 -07:00
config-hooks.txt Add stream event and hook for hashtag changes 2014-09-12 16:45:54 +02:00
config-labels.txt Label abbreviation feature is dead; kill it 2014-06-16 12:03:46 -07:00
config-login-register.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-mail.txt Documentation: Case consistencies for SEE ALSO 2014-03-24 19:02:08 -07:00
config-project-config.txt Add Change Owner group to documentation 2014-09-08 09:46:35 +00:00
config-reverseproxy.txt Apache/mod_jk/web server: Describe ForwardURICompatUnparsed option 2014-06-05 09:47:13 +02:00
config-sso.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-themes.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
config-validation.txt Introduce ref operation validation 2014-10-01 13:32:53 +00:00
config.defs Bump asciidoctorj to 1.5.0. 2014-08-22 10:32:51 -07:00
database-setup.txt Merge branch 'stable-2.8' into stable-2.9 2014-07-08 18:24:26 +09:00
dev-buck.txt Buck local_jar: Clarify how to overcome stale cache problem 2014-10-24 14:03:28 +09:00
dev-build-plugins.txt Add HOWTO documentation about building of plugins 2014-01-24 23:16:25 +01:00
dev-contributing.txt Merge "Document Vim setup for Git commit messages" 2014-10-24 13:03:28 +00:00
dev-design.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-eclipse.txt Fix typo in dev documentation 2014-09-22 01:17:53 +00:00
dev-inspector.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-plugins.txt Allow to manipulate All-Projects's group list in init step 2014-10-24 17:09:49 +02:00
dev-readme.txt Add hint how to use IntelliJ IDEA for Gerrit development 2014-04-27 21:16:25 +02:00
dev-release-deploy-config.txt Update link to Sonatype documentation about PGP signatures 2014-10-02 10:22:58 +02:00
dev-release-subproject.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
dev-release.txt Add buck rule to generate docs for static hosting. 2014-09-05 14:19:15 -07:00
dev-rest-api.txt Add a PUT example to rest api documentation 2014-07-10 20:44:53 -07:00
doc.css.in Rename doc.css to doc.css.in. 2014-08-29 10:20:52 -07:00
error-branch-not-found.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-change-closed.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-change-does-not-belong-to-project.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
error-change-not-found.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
error-change-upload-blocked.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-commit-already-exists.txt Merge branch 'stable-2.8' 2014-03-11 18:24:13 +09:00
error-contains-banned-commit.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-has-duplicates.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
error-invalid-author.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-invalid-changeid-line.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-invalid-committer.txt Fix reference to Forge Committer access right in documentation 2014-07-08 07:24:01 +00:00
error-messages.txt Improve reject message if Change-Id is in subject 2014-02-21 09:25:33 +01:00
error-missing-changeid.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
error-missing-subject.txt Improve reject message if Change-Id is in subject 2014-02-21 09:25:33 +01:00
error-multiple-changeid-lines.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-no-changes-made.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-no-common-ancestry.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-no-new-changes.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-non-fast-forward.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-a-gerrit-administrator.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-allowed-to-upload-merges.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-permitted-to-create.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-signed-off-by.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-not-valid-ref.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-permission-denied.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-prohibited-by-gerrit.txt Merge branch 'stable-2.8' 2014-02-21 10:37:47 +09:00
error-project-not-found.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
error-push-fails-due-to-commit-message.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
error-squash-commits-first.txt Minor improvements in the 'squash commits first' error documentation 2014-09-05 09:25:33 +09:00
error-upload-denied.txt Added searchbox to documentation. 2013-11-05 12:49:43 -08:00
gen_licenses.py Fix typo in license documentation generator 2014-06-03 22:26:49 +09:00
i18n-readme.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
index.txt Link new review UI documentation from new change screen welcome popup 2014-05-09 16:10:27 +02:00
install-j2ee.txt Fix broken formatting in Tomcat reverse proxy config documentation 2014-10-21 11:04:42 +09:00
install-quick.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
install.txt Fix inconsistency in documentation 2014-05-07 14:51:17 +02:00
intro-project-owner.txt Add section about commit validation to project owner guide 2014-07-16 06:50:39 +00:00
intro-quick.txt Consistently refer to Change-Id in documentation 2014-09-04 13:12:24 +09:00
js-api.txt JS API: Expose logged in user 2014-09-22 01:25:47 +00:00
json.txt Fix incorrect attribute name 2014-05-28 10:21:52 -05:00
Makefile Documentation/Makefile: Remove SVN publish support 2014-05-19 13:42:34 -07:00
pgm-daemon.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-gsql.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-index.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-init.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-LocalUsernamesToLowerCase.txt Doc: Consistently refer to "Web UI" rather than "WebUI" 2014-05-02 17:21:22 +09:00
pgm-prolog-shell.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
pgm-reindex.txt Document the --recheck-mergeable flag for the reindex program 2014-01-22 19:22:03 +09:00
pgm-rulec.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
project-configuration.txt Option to create a new change for every commit not in target 2014-09-11 15:10:08 +02:00
prolog-change-facts.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
prolog-cookbook.txt Fix Grammar and Clarity in "How to Write Submit Type" 2014-10-20 16:23:45 -07:00
replace_macros.py Add searchbox option to replace_macros.py. 2014-09-05 14:19:15 -07:00
rest-api-access.txt Update project REST API documentation to remove kind, add state 2014-04-23 12:35:10 -07:00
rest-api-accounts.txt Merge branch 'stable-2.10' 2014-10-21 17:18:09 +09:00
rest-api-changes.txt Make handling of web links consistent 2014-10-26 18:32:38 +00:00
rest-api-config.txt Fix unparsable JSON in Documentation 2014-08-13 15:00:44 +02:00
rest-api-documentation.txt Link new review UI documentation from new change screen welcome popup 2014-05-09 16:10:27 +02:00
rest-api-groups.txt Remove kind attribute from REST containers 2014-05-29 20:47:51 +00:00
rest-api-plugins.txt Remove kind attribute from REST containers 2014-05-29 20:47:51 +00:00
rest-api-projects.txt Add pagination options to ListBranches REST API 2014-10-16 14:20:14 +00:00
rest-api.txt More improvements in the REST API documentation index 2014-05-01 21:53:30 +09:00
user-changeid.txt Clarification of instructions for downloading the commit-msg hook 2014-10-06 18:15:10 +09:00
user-dashboards.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
user-notify.txt Add section about email notifications to project owner guide 2014-04-22 13:50:55 +02:00
user-review-ui.txt Add diff pref whether the diff table header should be auto hidden 2014-09-17 16:03:59 +02:00
user-search.txt Add search fields for # of changed lines. 2014-05-23 10:16:15 -07:00
user-signedoffby.txt Revert "== GERRIT" in documentation. 2014-03-25 19:44:49 +00:00
user-submodules.txt Use the new section title style in Asciidoctor. 2013-12-20 12:55:51 -08:00
user-upload.txt Merge branch 'stable-2.10' 2014-10-21 17:18:09 +09:00