b961a7d03d
There was an optimization to not add VisibleRefFilter if all refs of the project were visible to the calling user, because in this case it is not needed to evaluate all rules. This optimization is unneeded because a similar optimization exists within VisibleRefFilter. VisibleRefFilter checks if all refs except refs/meta/config are visible to the calling user and if yes only one separate permission check for refs/meta/config is done. Removing the optimization for the case where all refs are visible to the calling user makes this case only slightly slower, since there is only one additional permission check for the refs/meta/config branch now. On the other hand the case where a user can see all refs except refs/meta/config is a little faster now, since the check if all refs are visible is removed. By having VisibleRefFilter invoked always, we can now use it to add magic refs to the advertised ref set, which is e.g. required to support a magic refs/users/self ref (implemented in the follow-up change). Change-Id: Ic8f29b41f3abf23f99b59260956d543f815253cc Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit Code Review
Gerrit is a code review and project management tool for Git based projects.
Objective
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
Documentation
For information about how to install and use Gerrit, refer to the documentation.
Source
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Reporting bugs
Please report bugs on the issue tracker.
Contribute
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
Getting in contact
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
License
Gerrit is provided under the Apache License 2.0.
Build
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit
cd gerrit && buck build release
Install binary packages (Deb/Rpm)
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.