bae435c7a6
Binary files cannot be diffed like text, but for some binary changes, the diff algorithm does yield binary differences as text. With this change, the diff builder and processor are taught to render a special message for (non-image) binary diffs, and will ignore the text representation of the delta. Bug: Issue 4031 Change-Id: I2dcdbe9def006de827a37c35c42606bc1c9cf4fc
45 lines
1.7 KiB
JavaScript
45 lines
1.7 KiB
JavaScript
// Copyright (C) 2017 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the 'License');
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an 'AS IS' BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
(function(window, GrDiffBuilderSideBySide) {
|
|
'use strict';
|
|
|
|
// Prevent redefinition.
|
|
if (window.GrDiffBuilderBinary) { return; }
|
|
|
|
function GrDiffBuilderBinary(diff, comments, prefs, projectName, outputEl) {
|
|
GrDiffBuilder.call(this, diff, comments, prefs, projectName, outputEl);
|
|
console.log('binary village');
|
|
}
|
|
|
|
GrDiffBuilderBinary.prototype = Object.create(GrDiffBuilder.prototype);
|
|
GrDiffBuilderBinary.prototype.constructor = GrDiffBuilderBinary;
|
|
|
|
// This method definition is a no-op to satisfy the parent type.
|
|
GrDiffBuilderBinary.prototype.addColumns = function(outputEl, fontSize) {};
|
|
|
|
GrDiffBuilderBinary.prototype.buildSectionElement = function() {
|
|
const section = this._createElement('tbody', 'binary-diff');
|
|
const row = this._createElement('tr');
|
|
const cell = this._createElement('td');
|
|
const label = this._createElement('label');
|
|
label.textContent = 'Difference in binary files';
|
|
cell.appendChild(label);
|
|
row.appendChild(cell);
|
|
section.appendChild(row);
|
|
return section;
|
|
};
|
|
|
|
window.GrDiffBuilderBinary = GrDiffBuilderBinary;
|
|
})(window, GrDiffBuilderSideBySide);
|