292fa154c1
Having a standard tool for formatting saves reviewers' valuable time. google-java-format is Google's standard formatter and is somewhat inspired by gofmt[1]. This commit formats everything using google-java-format version 1.2. The downside of this one-off formatting is breaking blame. This can be somewhat hacked around with a tool like git-hyper-blame[2], but it's definitely not optimal until/unless this kind of feature makes its way to git core. Not in this change: * Tool support, e.g. Eclipse. The command must be run manually [3]. * Documentation of best practice, e.g. new 100-column default. [1] https://talks.golang.org/2015/gofmt-en.slide#3 [2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html [3] git ls-files | grep java$ | xargs google-java-format -i Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3 Signed-off-by: David Pursehouse <dpursehouse@collab.net>
62 lines
2.1 KiB
Java
62 lines
2.1 KiB
Java
// Copyright (C) 2016 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package com.google.gerrit.server;
|
|
|
|
import static java.util.stream.Collectors.toList;
|
|
|
|
import com.google.gerrit.server.config.GerritServerConfig;
|
|
import com.google.inject.Injector;
|
|
import com.google.inject.Key;
|
|
import com.google.inject.Module;
|
|
import com.google.inject.ProvisionException;
|
|
import java.util.Arrays;
|
|
import java.util.List;
|
|
import org.eclipse.jgit.lib.Config;
|
|
import org.slf4j.Logger;
|
|
import org.slf4j.LoggerFactory;
|
|
|
|
/** Loads configured Guice modules from {@code gerrit.installModule}. */
|
|
public class LibModuleLoader {
|
|
private static final Logger log = LoggerFactory.getLogger(LibModuleLoader.class);
|
|
|
|
public static List<Module> loadModules(Injector parent) {
|
|
Config cfg = getConfig(parent);
|
|
return Arrays.stream(cfg.getStringList("gerrit", null, "installModule"))
|
|
.map(m -> createModule(parent, m))
|
|
.collect(toList());
|
|
}
|
|
|
|
private static Config getConfig(Injector i) {
|
|
return i.getInstance(Key.get(Config.class, GerritServerConfig.class));
|
|
}
|
|
|
|
private static Module createModule(Injector injector, String className) {
|
|
Module m = injector.getInstance(loadModule(className));
|
|
log.info("Installed module {}", className);
|
|
return m;
|
|
}
|
|
|
|
@SuppressWarnings("unchecked")
|
|
private static Class<Module> loadModule(String className) {
|
|
try {
|
|
return (Class<Module>) Class.forName(className);
|
|
} catch (ClassNotFoundException | LinkageError e) {
|
|
String msg = "Cannot load LibModule " + className;
|
|
log.error(msg, e);
|
|
throw new ProvisionException(msg, e);
|
|
}
|
|
}
|
|
}
|