292fa154c1
Having a standard tool for formatting saves reviewers' valuable time. google-java-format is Google's standard formatter and is somewhat inspired by gofmt[1]. This commit formats everything using google-java-format version 1.2. The downside of this one-off formatting is breaking blame. This can be somewhat hacked around with a tool like git-hyper-blame[2], but it's definitely not optimal until/unless this kind of feature makes its way to git core. Not in this change: * Tool support, e.g. Eclipse. The command must be run manually [3]. * Documentation of best practice, e.g. new 100-column default. [1] https://talks.golang.org/2015/gofmt-en.slide#3 [2] https://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-hyper-blame.html [3] git ls-files | grep java$ | xargs google-java-format -i Change-Id: Id5f3c6de95ce0b68b41f0a478b5c99a93675aaa3 Signed-off-by: David Pursehouse <dpursehouse@collab.net>
46 lines
1.6 KiB
Java
46 lines
1.6 KiB
Java
// Copyright (C) 2010 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License
|
|
|
|
package com.google.gerrit.server.config;
|
|
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.gerrit.server.account.GroupBackend;
|
|
import com.google.gerrit.server.group.SystemGroupBackend;
|
|
import com.google.gerrit.server.util.ServerRequestContext;
|
|
import com.google.gerrit.server.util.ThreadLocalRequestContext;
|
|
import com.google.inject.Inject;
|
|
import java.util.Collections;
|
|
import org.eclipse.jgit.lib.Config;
|
|
|
|
public class GitReceivePackGroupsProvider extends GroupSetProvider {
|
|
@Inject
|
|
public GitReceivePackGroupsProvider(
|
|
GroupBackend gb,
|
|
@GerritServerConfig Config config,
|
|
ThreadLocalRequestContext threadContext,
|
|
ServerRequestContext serverCtx) {
|
|
super(
|
|
gb,
|
|
threadContext,
|
|
serverCtx,
|
|
ImmutableList.copyOf(config.getStringList("receive", null, "allowGroup")));
|
|
|
|
// If no group was set, default to "registered users"
|
|
//
|
|
if (groupIds.isEmpty()) {
|
|
groupIds = Collections.singleton(SystemGroupBackend.REGISTERED_USERS);
|
|
}
|
|
}
|
|
}
|