opendev/gerrit
Code Issues Proposed changes
bbd286781c
gerrit/lib
History
David Ostrovsky e27a404a3e Bump args4j version to 2.0.29 
There is pending upgrade for review for years now to version 2.33: [1],
that appears to be too introusive change. There are two issues:

* Collision with rules_closure's and closure-templates's args4j version
* Non trivial changes in gerrit core to adapt to newer args4j version

Dismantle those issues, by upgrading to intermediate version: 2.0.29.

Re-fetch args4j twice: one for rules_closure to work properly with
ancient args4j version, while renaming the internal one to the more
recent version: args4j-intern.

Needless to say, that we have uploaded these PRs to both projects:
rules_closure and closure-templates that were more or less rejected,
so that we don't hope that args4j is going to be upgraded upstream,
thus keeping this status quo of double fetching: [2],[3].

The reason we need this change is dependency of gitblit-plugin on more
recent version so that we are getting classpath collision. Another
alternative that was considered (but abandoned) is to downgrade args4j
version in gitblit to the same ancient version used by gerrit core.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/67793
[2] https://github.com/bazelbuild/rules_closure/pull/262
[3] https://github.com/google/closure-templates/pull/155

Change-Id: I5ec6645b92d54fccc03a723b7b50c50a99393d57
2018-08-01 11:09:56 +02:00
..
antlr Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
asciidoctor AsciiDoctor: Format with google-java-format version 1.6 2018-06-06 08:45:32 +09:00
auto Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
ba-linkify Manually add @license to ba-linkify.js 2018-03-26 14:14:57 -04:00
bouncycastle Don't ship bouncycastle libraries in plugin API 2017-04-07 07:38:04 +02:00
codemirror Apply buildifier to .bzl files. 2018-07-10 20:38:52 +09:00
commons Move commons-io from lib/BUILD to lib/commons/BUILD 2018-06-13 20:01:44 +09:00
dropwizard Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
easymock Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
elasticsearch-rest-client Elasticsearch: replace native API in prod w/ REST 2018-05-31 08:06:19 +09:00
flogger Add dependency to Flogger 2018-06-05 13:06:05 +02:00
fonts Merge "Adjust file mode of Roboto fonts" into stable-2.15 2018-07-25 07:30:06 +00:00
greenmail Remove Buck based build 2017-01-23 12:44:58 +00:00
guice Bump guice version to 4.2.0 2018-07-19 08:42:40 +09:00
gwt Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
highlightjs Mention how to download closure-compiler to build highlight.js 2018-07-23 17:18:46 +00:00
httpcomponents Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
jackson Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
jetty Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
jgit JGit: Use Javadoc from 5.0.1.201806211838-r 2018-07-12 18:16:38 +09:00
js Replace vulcanize with bundle_assets build rule 2018-07-18 11:20:14 -07:00
jsoup Remove one last buck file from gerrit's core 2017-01-27 19:41:56 +00:00
log Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
lucene Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
mail Remove Buck based build 2017-01-23 12:44:58 +00:00
mime4j Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
mina Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
openid Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
ow2 Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
polymer_externs Bazel: Replace native {http,git}_archive with Skylark rules 2018-06-05 05:13:58 +00:00
powermock Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
prolog Merge branch 'stable-2.14' into stable-2.15 2018-07-11 08:35:07 +09:00
testcontainers Bazel: Harmonize names of external repositories 2018-06-13 11:38:03 +09:00
truth Upgrade Truth to 0.42 2018-07-24 10:57:18 +01:00
BUILD Bump args4j version to 2.0.29 2018-08-01 11:09:56 +02:00
guava.bzl Upgrade guava to 25.1-jre 2018-05-25 09:52:36 +09:00
LICENSE-antlr
LICENSE-Apache1.1
LICENSE-Apache2.0
LICENSE-args4j Synchronize args4j license with upstream 2016-06-07 18:59:40 +00:00
LICENSE-asciidoctor Add correct license for asciidoctor 2016-08-19 04:05:06 +00:00
LICENSE-automaton Synchronize automaton license with upstream 2016-06-09 09:31:58 +00:00
LICENSE-ba-linkify Move ba-linkify.js to lib 2018-03-26 14:14:57 -04:00
LICENSE-bouncycastle Synchronize bouncy castle license with upstream 2016-06-10 06:31:21 +02:00
LICENSE-CC0-1.0 Add support for elliptic curve/ed25519 SSH keys 2017-03-28 15:26:29 +00:00
LICENSE-CC-BY3.0-unported Clarify that the CC-BY 3.0 license is the unported version 2016-09-21 11:19:22 +02:00
LICENSE-clippy
LICENSE-codemirror-minified Use a pre-built minified CodeMirror in the release build 2016-04-04 20:33:27 -04:00
LICENSE-codemirror-original Use a pre-built minified CodeMirror in the release build 2016-04-04 20:33:27 -04:00
LICENSE-diffy Diffy should use the unported CC-BY 3.0 license 2016-09-21 11:26:15 +02:00
LICENSE-DO_NOT_DISTRIBUTE
LICENSE-elasticsearch Elasticsearch: replace native API in prod w/ REST 2018-05-31 08:06:19 +09:00
LICENSE-es6-promise Add es6-promise for Internet Explorer 2016-09-13 15:14:32 +00:00
LICENSE-fetch Add fetch polyfill for use in all supported browsers 2016-03-03 23:49:18 -05:00
LICENSE-h2
LICENSE-highlightjs Syntax highlighting 2016-07-25 13:47:30 -07:00
LICENSE-icu4j Adds the Soy library and injects it via EmailArguments 2016-08-22 09:45:33 -07:00
LICENSE-jgit
LICENSE-jsch
LICENSE-jsoup Add jsoup to Buck and Bazel 2016-11-16 01:24:59 +00:00
LICENSE-moment Recognize time format preferences. 2016-03-15 15:22:39 -07:00
LICENSE-MPL1.1
LICENSE-OFL1.1 Serve fonts from Gerrit instead of Google Fonts. 2016-04-01 13:11:02 -04:00
LICENSE-ow2
LICENSE-page.js Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-polymer Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-postgresql
LICENSE-prologcafe
LICENSE-promise-polyfill Build bower_components with buck 2015-11-12 19:01:53 -05:00
LICENSE-protobuf Add dependency on the Google protocol buffer library 2013-09-10 15:59:25 -07:00
LICENSE-PublicDomain
LICENSE-silk_icons Synchronize license for silk icons 2016-09-21 11:04:46 +02:00
LICENSE-slf4j
LICENSE-testcontainers Acceptance tests: Replace embedded ES with docker testcontainer 2018-05-31 08:13:48 +09:00
LICENSE-xz Download commands: Add JGit archive 2014-03-03 23:34:46 +00:00