Files
gerrit/gerrit-server/src/test/java/com/google/gerrit/server/util
Stefan Beller be37ca92ef SubmoduleSectionParser: do not use mocks for testing
Mock tests are testing too much the internals, which we don't
really need to test. All we're interested in is correctness of
the outcome, so we test from the outside now. This will make
refactoring in the future way easier. Also this shifts the
attention to testing the right thing.

Looking at the `execute` method, which follows the structure
of SubmoduleSectionParser.parse (e.g. the while loop chopping
off the last '/') doesn't provide an enhanced understanding to
the reader, who may want to treat the class as a black box
and only see what goes in and what comes out.

Change-Id: Icdf2394e38b42fa7ebd0e25d35fceb11cf17b9e0
2016-05-25 10:05:58 -07:00
..
2014-08-20 10:23:06 +09:00