opendev/gerrit
Code Issues Proposed changes
RETIRED, Gerrit as used by OpenStack
14,166 Commits 1 Branch 360 Tags 120 MiB
be910538a5
Go to file
Hugo Arès be910538a5 Correct file list when comparing patchsets 
When comparing a patchset with another one, the added and deleted files
were not displayed properly:

-change 1,1 is adding file a, c and deleting d
-change 1,2 is adding file a, b and deleting d

When comparing 1,1 to 1,2, the file changed list should show that b was
added and c was deleted but instead it was showing that only b was
added.

When comparing 1,2 to 1,1, the file changed list should show that b was
deleted and c was added but instead it was showing that only c was
added.

I know that this behavior was intended[1], i.e. when comparing patchset
with each other, the file list will not include files not in the base.

The problem is that behavior was perceived as a bug by our users. When
they compare patchset between each others, they expect to see the full
list of files changed, even if the file is not in the base.

[1] https://gerrit-review.googlesource.com/#/c/57086/4//COMMIT_MSG@10

Change-Id: I1bd7e6354617d921a77115c47543328a4a66999f
(cherry picked from commit 314a096181)
2015-06-26 14:27:43 +00:00
.settings RFC: Enable Eclipse warning about fall-through cases in switch statements 2015-02-03 12:17:49 +09:00
bucklets Rename __standalone_mode__ to STANDALONE_MODE 2014-11-24 08:44:12 +00:00
contrib Fix minor python code style issues 2014-12-18 02:51:06 +00:00
Documentation Pack prettify.min.{js,css} into documentation. 2015-06-26 03:04:09 +00:00
gerrit-acceptance-tests Correct file list when comparing patchsets 2015-06-26 14:27:43 +00:00
gerrit-antlr Support change~branch~id in query syntax 2014-12-10 09:55:08 -08:00
gerrit-cache-h2 H2: Don't show stack trace when failing to build BloomFilter 2015-04-28 07:43:29 +00:00
gerrit-common Make LabelTypeIT tests assume copy-score defaults now initialized herein 2015-03-19 13:55:20 +09:00
gerrit-extension-api Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-gwtdebug Organize imports 2014-12-18 11:16:03 +09:00
gerrit-gwtexpui Fix some warnings raised by CheckStyle 2015-02-12 19:38:30 +09:00
gerrit-gwtui Revert "Treat the search box oracle as a remote oracle" 2015-06-20 09:17:00 +02:00
gerrit-gwtui-common Remove unused "remove reviewer" image 2015-01-08 18:39:58 +09:00
gerrit-httpd Bump JGit to v4.0.0.201506090130-r 2015-06-09 17:50:55 +02:00
gerrit-launcher Fix some warnings raised by CheckStyle 2015-02-12 19:38:30 +09:00
gerrit-lucene Merge branch 'stable-2.10' into stable-2.11 2015-03-29 20:49:13 +01:00
gerrit-main Build Main for Java 1.2 2013-11-30 01:53:00 -08:00
gerrit-oauth Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-openid Merge branch 'stable-2.10' into stable-2.11 2015-05-07 10:37:48 +09:00
gerrit-patch-commonsnet Replace 'for' loop with 'foreach' 2013-12-04 01:02:53 +04:00
gerrit-patch-jgit Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-pgm Bump JGit to v4.0.0.201506090130-r 2015-06-09 17:50:55 +02:00
gerrit-plugin-api Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-plugin-archetype Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-plugin-gwt-archetype Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-plugin-gwtui Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-plugin-js-archetype Set version to 2.11.2 2015-06-25 02:25:32 +00:00
gerrit-prettify Pack prettify.min.{js,css} into documentation. 2015-06-26 03:04:09 +00:00
gerrit-reviewdb Move edit ref name methods from ChangeEditUtil to RefNames 2015-04-16 19:17:29 +09:00
gerrit-server Correct file list when comparing patchsets 2015-06-26 14:27:43 +00:00
gerrit-solr Add index configuration to specify maximum possible limit 2015-01-20 11:04:08 -08:00
gerrit-sshd Require 'View Plugins' capability to list plugins through SSH 2015-05-07 01:56:30 +00:00
gerrit-util-cli Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-util-http Refactor RequestUtil into a separate package 2014-10-30 15:35:26 -07:00
gerrit-util-ssl Turn on many more Eclipse warnings, and fix them 2014-10-29 15:00:17 -07:00
gerrit-war Set version to 2.11.2 2015-06-25 02:25:32 +00:00
lib Update JGit to 4.0.1.201506240215-r 2015-06-24 12:33:00 +02:00
plugins Update reviewnotes plugin to latest revision 2015-06-10 21:20:19 +09:00
ReleaseNotes Update 2.11.1 release notes 2015-06-12 14:40:28 +09:00
tools Force javac to use -encoding UTF-8 2015-02-26 00:05:30 +00:00
website/releases Releases: Update website to use Cloud Storage v1 API 2014-11-21 12:22:59 -08:00
.buckconfig Add buck build soyc to output GWT split point report 2015-01-15 04:40:28 +00:00
.buckversion Update buck version to same as master 2015-04-14 14:47:50 +09:00
.gitignore Add '/.apt_generated' and '/.factorypath' to .gitignore 2015-04-29 13:56:33 +02:00
.gitmodules Add singleusergroup plugin 2013-11-09 07:45:00 +01:00
.mailmap Update mailmap 2015-01-23 17:56:02 +09:00
.pydevproject Update PyDev project to use Python 2.7 2014-10-02 15:16:44 +09:00
.watchmanconfig Watchman: Add buck-out dir to ignored directories 2014-08-21 07:32:37 +02:00
BUCK Update Buck and use gwt_binary() 2014-05-19 11:41:31 -07:00
COPYING Initial project setup of Gerrit 2 2008-11-14 16:59:34 -08:00
INSTALL Remove Gerrit 1.x to 2.x import tools 2009-03-27 20:20:10 -07:00
SUBMITTING_PATCHES Update push URL in SUBMITTING_PATCHES 2012-03-29 00:57:14 -04:00
VERSION Set version to 2.11.2 2015-06-25 02:25:32 +00:00